cheribsd-release: build vm images #413
Open
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, a bit more poking shows there's no METALOG use in the disk image so ownership will all be wrong so I need to clean that up on the CheriBSD side (or see if the foundation has a WIP far enough along to help). |
brooksdavis
force-pushed
the
release-vm-images
branch
2 times, most recently
from
5688006 to
c9d0bab
Compare
jrtc27
reviewed
Apr 3, 2025
jrtc27
reviewed
Apr 3, 2025
jrtc27
reviewed
Apr 3, 2025
jrtc27
reviewed
Apr 3, 2025
brooksdavis
force-pushed
the
release-vm-images
branch
3 times, most recently
from
8ac2066 to
d6e56a8
Compare
F824 Doesn't seem to understand methods of modifying a variable that
aren't direct assignment.
./pycheribuild/projects/run_fvp.py:292:21: F824 `nonlocal extra_args` is unused: name is never assigned in scope
nonlocal extra_args
^
./pycheribuild/projects/run_qemu.py:447:13: F824 `nonlocal have_9pfs_support` is unused: name is never assigned in scope
nonlocal have_9pfs_support
^
./pycheribuild/projects/run_qemu.py:448:13: F824 `nonlocal have_smbfs_support` is unused: name is never assigned in scope
nonlocal have_smbfs_support
^
./pycheribuild/projects/run_qemu.py:449:13: F824 `nonlocal qemu_command` is unused: name is never assigned in scope
nonlocal qemu_command
^
4 F824 `nonlocal extra_args` is unused: name is never assigned in scope
Error: Process completed with exit code 1.
I've put support behind a flag as older CheriBSD trees will break without patchs. If you add the flag --cheribsd-release/build-vm-images to a cheribsd-release-* target and the source tree supports it, an image or images will be built as part of the release process.
brooksdavis
force-pushed
the
release-vm-images
branch
from
d6e56a8 to
36b0baf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with the changes in
CTSRD-CHERI/cheribsd#2360 this produces ciimages/FreeBSD-15.0-CURRENT-arm64-aarch64c-BASIC-CI-ufs.raw.xz in the output directory for cheribsd-release-morello-purecap. The result is untested, but likely a usable starting point if cross build actually works.
I think we'll likely require some manual testing before this lands or it needs to got under a switch, but it should let people try it out.