Fix bluespec-compiler for Ubuntu 24.04 to 26.04#497
Conversation
| def install(self, **kwargs): | ||
| try: | ||
| self.run_cmd("cabal", "v1-update") | ||
| self.run_cmd("cabal", "update") |
There was a problem hiding this comment.
Hm, so v1-update has been removed but v1-install remains? I'd naively assume they'd go together
There was a problem hiding this comment.
It seems that way - 'update; v1-install' is what the upstream Bluespec repo recommends.
I tried v2-install but ran into problems as it needs to do make GHC="ghc -package-env default" and I couldn't get that to work (I don't know if cheribuild was failing to escape that correctly, but even when I did it by hand it didn't work).
There was a problem hiding this comment.
Interesting. I assume this is also fine on 22.04, but could you please check that, given it's still supported and we have a bunch of machines (e.g. technos) on it?
There was a problem hiding this comment.
Looks like the cabal install worked on 22.04, but it won't build with the supplied ghc-8.8.4:
[165 of 227] Compiling RSchedule ( RSchedule.hs, /home/atm26/cheri/bsc/src/comp/../../build/comp/RSchedule.o )
RSchedule.hs:51:10: error:
• Illegal instance declaration for ‘PPrint RAT’
(All instance types must be of the form (T t1 ... tn)
where T is not a synonym.
Use TypeSynonymInstances if you want to disable this.)
• In the instance declaration for ‘PPrint RAT’
|
51 | instance PPrint RAT where
| ^^^^^^^^^^
There was a problem hiding this comment.
Thanks; given it got that far the cabal side of things here is probably fine. Can you please squash the formatting commits into the second one, then we can merge this?
tmarkettos
force-pushed
the
atm26-bluespec-fix
branch
from
35dba8d to
669bbb5
Compare
3 participants
This PR fixes the Haskell setup for building bluespec-compiler. It also corrects a dependency apt package name.
Tested on Ubuntu 24.04, 25.10 and 26.04.