Reactive policies #74
Conversation
…which turns on and off policies based on given temperature. Bets_skip performs skipping of a single task in each window while temperature is above threshold. Bets_soft_throttle reduces frequencies to closest lower frequency when threshold is overstepped. Bets_hard_throttle set frequencies to minimum when temperature is above threshold.
…tures over last 10 measurements, reduced temperature window.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 36.39% 34.79% -1.61%
==========================================
Files 46 50 +4
Lines 2459 2578 +119
Branches 1117 1172 +55
==========================================
+ Hits 895 897 +2
- Misses 1094 1209 +115
- Partials 470 472 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| protected: | ||
| // currently, this is hardcoded for i.MX8, but should be quite simply extensible | ||
| // for other CPU cluster layouts | ||
| std::array<CpufreqPolicy *, 2> policies{ &pm.get_policy("policy0"), &pm.get_policy("policy4") }; |
There was a problem hiding this comment.
Bylo by lepší to předělat, aby to nebylo platformě závislé. Podobně jako per_process.hpp byla upravena z imx8_per_process.hpp.
| float upper_threshold; | ||
| float lower_threshold; |
There was a problem hiding this comment.
V komentáři (nebo rovnou ve jménu proměnné) zmínit, že se jedna o teplotu.
| time_t timer; | ||
| const time_t limit = 10; |
There was a problem hiding this comment.
time_t je definován jako čas v sekundách. Myslím, že bychom někdy mohli chtít mít ten čas i kratší než sekundu, tak bych použil čas v milisekundách, jako se používá ve zbytku demosu.
Bylo by lepší použít C++ datové typy ze std::chrono, konkrétně asi time_point a duration.
| float lower_threshold; | ||
| time_t timer; | ||
| const time_t limit = 10; | ||
| bool temperature_inertia_period = false; |
There was a problem hiding this comment.
Je divné, že něco, co se nazývá period je typu bool. V názvu proměnné (asi) chybí sloveso.
| Bets_policy(const std::string &temperature_threshold) | ||
| { | ||
| upper_threshold = std::stof(temperature_threshold); | ||
| lower_threshold = upper_threshold - 1; |
There was a problem hiding this comment.
Bylo by lepší, kdyby to byl 2. (nepovinný) parametr.
| load(win); | ||
| sort_candidates(); |
There was a problem hiding this comment.
Myslím, že load a sort_candidate není potřeba volat pokaždé, ale stačilo by to vykonat jednou na začátku. Myslím, že metoda validate je ideální místo, kde by se to mělo udělat.
| this->level = 5; | ||
| } | ||
| int skip_counter = 0; | ||
| for (int j = 0; j < win.slices.size(); j++){ |
There was a problem hiding this comment.
Když iterujete přes container, je přehlednější používat tzv. range-based for: for (auto &slice : win.slices) slice.to_be_skipped = false;.
| } | ||
| load(win); | ||
| sort_candidates(); | ||
| // Iterate trough candidates, until up to the level amounth of them is skipped, but at least 1 is kept. |
There was a problem hiding this comment.
Proč je potřeba 1 nechávat? Když by se to hodně přehřívalo, je možné klidně přeskočit všechny.
| void sort_candidates(){ | ||
| std::sort(candidates.begin(), candidates.end(), cmp); | ||
| } | ||
|
|
||
| void safe_pushback(std::string key){ | ||
| for (auto &p : candidates){ | ||
| if (p.first == key){ | ||
| return; | ||
| } | ||
| } | ||
| candidates.push_back(std::pair<std::string, int>(key, 0)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Pokud se použijí datové sktuktury navržené výše, tohle bude zbytečné.
| int is_present(std::string key){ | ||
| for (int i = 0; i < present.size(); i++){ | ||
| if (present[i] == key){ | ||
| return i; | ||
| } | ||
| } | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
Pokud se použijí datové sktuktury navržené výše, is_present bude zbytečné.
Contains reactive policies. They take single argument, that is temperute level.
Bets_policy.hpp contains general policy framework, which reacts on temperature threshold overstepping and increases "level" variable. Higher level means more strict policy application. If level != 0, virtual function execute_policy is executed. Otherwise it acts like imx8_per_window policy.
Bets_skip.hpp contains skipping policy. Iterates over all tasks in each window and skips up to 5 of them (to keep one running), based on "level" variable.
Bets_soft_throttle.hpp reduces frequency of tasks in each window by 1 - 3 levels based on "level" variable.