Update pde class to enable multiple inputs for the FEniCS PDE model #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
chaozg
approved these changes
Jun 16, 2025
chaozg
left a comment
chaozg
left a comment
There was a problem hiding this comment.
Hi @amal-ghamdi , everything in this PR looks good to me 👍
nabriis
approved these changes
Jul 2, 2025
Contributor
nabriis
left a comment
nabriis
left a comment
There was a problem hiding this comment.
Thanks @amal-ghamdi. LGTM. I had a minor suggestion.
Collaborator
Author
|
Thank you @nabriis for your review. I am requesting a re-review :) |
Collaborator
Author
|
oh never mind you already approved @nabriis :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #87
closes #89