checkpoint added #292
Open
checkpoint added #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you very much for adding the checkpoint PR @babakmaboudi! Super excited to get this sampler rework into CUQIpy! It has a lot of potential. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the rework of the CUQIpy samplers:
The parent calss "Sampler_new" is a generic class for which it handles samples. Ideally it should also handle sampler management but at this point it doesn't do anything.
The child class "ProposalBasedSampler" handles the proposal and acceptance/rejection history. In ideal case pCN should pass its prior to the init of ProposalBasedSampler as the proposal strategy. But I couldn't make that work.
The grandchild class MH or pCN is in charge of proposing and accepting/rejecting a single sample. ProposalBasedSampler is in charge of tracking the history. However, I didn't mange to make pCN work.
Let me know if you have questions.
Babak