-
Notifications
You must be signed in to change notification settings - Fork 10
Enable general observation function for PDE, and accessing original solution (or other observable quantities) #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
31d2138 to
9b68877
Compare
chaozg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amal-ghamdi , thanks for implementing this feature.
Do you plan to have more demos on clarifying how this observation function could be used? For example, I wonder with an observation_map like lambda u, grid_obs: u**2, how do we compute the jacobian? I mean could the gradient be computed automatically? Is the chain product broken or 'preserved'? I guess a more common observation would be lambda u, grid:u[some indices]. Can we also compute the gradient in this case and use ULA/NUTS?
Many thanks @chaozg for your review. I updated a howto (demos/howtos/TimeDependentLinearPDE.py) we already have to show some usage of the On the posterior level, one can enable FD gradient, regardless of the underlying model. |
chaozg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jakobsj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and to comprehensively address the comments received. Only some very minor in line comments, so approving now.
Co-authored-by: Jakob Sauer Jørgensen <[email protected]>
Co-authored-by: Jakob Sauer Jørgensen <[email protected]>
closes #620