Partitioning: Enhance error message

[alosslessdev]

I have found the minimum size required to be 2 gb. Also grammar fix

[ptr1337]

I have found the minimum size required to be 2 gb. Also grammar fix

It depends on the bootloader. When doing manual partitioning it will only "warn".
At limine we increased the size to 4GB now /boot, due limine-snapper-sync needs a lot of space.

[alosslessdev]

Can we say that the minimum size is 4 GB to allow the user to change bootloaders?

[ventureoo]

Recommended size is depend on selected bootloader by user, so you should query it to print accurate warning:

diff --git a/src/modules/partition/gui/ChoicePage.cpp b/src/modules/partition/gui/ChoicePage.cpp
index 0fac14f3b..c6b2aacd9 100644
--- a/src/modules/partition/gui/ChoicePage.cpp
+++ b/src/modules/partition/gui/ChoicePage.cpp
@@ -1253,7 +1253,9 @@ ChoicePage::setupEfiSystemPartitionSelector()
         if ( !PartUtils::isEfiFilesystemRecommendedSize( efiPartition ) )
         {
             text += QStringLiteral( "<br/><font color=\"red\">" )
-                    + tr( "The EFI system partition is too small, please use manual partition." )
+                    + tr( "The EFI system partition is too small, please use manual partition ",
+                          "and increase its size to %1 MB or greater")
+                        .arg(PartUtils::efiFilesystemRecommendedSize() / 1024 / 1024)
                     + QStringLiteral( "</font>" );
         }
         m_efiLabel->setText( text );

[alosslessdev]

Recommended size is depend on selected bootloader by user, so you should query it to print accurate warning:

diff --git a/src/modules/partition/gui/ChoicePage.cpp b/src/modules/partition/gui/ChoicePage.cpp
index 0fac14f3b..c6b2aacd9 100644
--- a/src/modules/partition/gui/ChoicePage.cpp
+++ b/src/modules/partition/gui/ChoicePage.cpp
@@ -1253,7 +1253,9 @@ ChoicePage::setupEfiSystemPartitionSelector()
         if ( !PartUtils::isEfiFilesystemRecommendedSize( efiPartition ) )
         {
             text += QStringLiteral( "<br/><font color=\"red\">" )
-                    + tr( "The EFI system partition is too small, please use manual partition." )
+                    + tr( "The EFI system partition is too small, please use manual partition ",
+                          "and increase its size to %1 MB or greater")
+                        .arg(PartUtils::efiFilesystemRecommendedSize() / 1024 / 1024)
                     + QStringLiteral( "</font>" );
         }
         m_efiLabel->setText( text );

done