security: Ensure that reports does not work as guest#7167
Merged
Conversation
TheWitness
requested review from
bmfmancini,
browniebraun,
Copilot,
netniV and
xmacan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens access control in Cacti’s web UI by preventing the Reporting pages from being accessible via the guest account, ensuring include/auth.php enforces a real login for report management.
Changes:
- Removed
$guest_account = true;fromreports_user.php. - Removed
$guest_account = true;fromreports_admin.php.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| reports_user.php | Stops enabling guest authentication on the user reporting page so auth.php requires a logged-in session. |
| reports_admin.php | Stops enabling guest authentication on the admin reporting page so auth.php requires a logged-in session. |
browniebraun
approved these changes
May 26, 2026
bmfmancini
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.