fix(security): anchor thumbnails filter and parameterize header-node query#7176
Merged
TheWitness merged 1 commit intoJun 3, 2026
Merged
Conversation
…query graph_view anchors the thumbnails FILTER_VALIDATE_REGEXP to ^(true|false)$, and create_all_header_nodes() uses a ? placeholder for the item id it already binds via db_fetch_cell_prepared(). Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
changed the title
somethingwithproof
force-pushed
the
fix/1.2.x-input-validation
branch
from
bda3284 to
f59357e
Compare
TheWitness
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small hardening fixes for 1.2.x:
graph_view.php: anchor thethumbnailsFILTER_VALIDATE_REGEXP to^(true|false)$(previously unanchored).lib/api_automation.php:create_all_header_nodes()uses a?placeholder for the item id it already binds viadb_fetch_cell_prepared()(was string-concatenated).Base: 1.2.x. Rebased onto the current 1.2.x tip so the diff is limited to these two files.