fix(poller): coerce invalid SCRIPT/SCRIPT_PHP output to U in cmd.php#7180
Merged
TheWitness merged 1 commit intoJun 3, 2026
Merged
Conversation
The SCRIPT and SCRIPT_PHP branches logged an invalid (non-numeric, shape-invalid) collector response but left $output as the raw junk, unlike the SNMP branch and cmd_realtime.php which reset it to 'U'. Mirror them so a bad value is stored as U rather than a raw string in poller_output. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
TheWitness
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SCRIPT and SCRIPT_PHP collection branches in
cmd.phplog an invalid (non-numeric, shape-invalid) script/script-server response but leave$outputas the raw junk string, unlike the SNMP branch andcmd_realtime.php, which reset it to'U'. Downstreamprocess_poller_output/boost coerce non-numeric values to U before the RRD update, so this is a consistency/robustness fix (a raw bad value is otherwise stored inpoller_outputbefore being discarded), not a security issue. Base: 1.2.x.