Skip to content

Adding Linux ARM Builds to CI #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding Linux ARM Builds to CI #52

wants to merge 2 commits into from

Conversation

jmwright
Copy link
Member

@jmwright jmwright commented Apr 7, 2025

No description provided.

Copy link
Collaborator

@bernhard-42 bernhard-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In .github/workflows/build-ocp.yml the os array appears three times and the include sections would need to be updated.

I would be very surprised if it would build immediately, given the hassle I had to get the other 4 os flavors to work ...

Copy link
Collaborator

@bernhard-42 bernhard-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good.

I think the next step is to check the conditions. Currently I use

  • if: runner.os == 'Linux'
  • if [[ "$RUNNER_OS" == "Linux" ]]; then

Does the github workflow use these conditions for both intel and arm ubuntu?
And if we need to distinguish, how would that be done.

I currently don't have time to work on it.
However, if we have a tag on the latest working version, then let's merge it and give it a try to learn. If things go south, we can go back to the tag.

@bernhard-42
Copy link
Collaborator

And another question is, whether we should align the ubuntu version for intel and arm Linux?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants