fix issue login navigation #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 20, 2025
Closed
Shahd-Hatem
approved these changes
Aug 20, 2025
Test Results 146 files 146 suites 3m 4s ⏱️ Results for commit 78b1571. ♻️ This comment has been updated with latest results. |
AbdelrahmanKarim
approved these changes
Aug 20, 2025
YoussefmSaber
approved these changes
Aug 20, 2025
Comment on lines
55
to
74
| fun updateStateAfterLoggingIn() { | ||
| tryToCall( | ||
| block = { accountUseCase.getAccountDetails() }, | ||
| onSuccess = { | ||
| getMovieInFavorite() | ||
| getMovieIsRated() | ||
| }, | ||
| onError = {} | ||
| ) | ||
| updateState { | ||
| it.copy( | ||
| isRateBottomSheetOpen = false, | ||
| isRatedSuccessBottomSheetOpen = false, | ||
| isNoAccountBottomSheetOpen = false, | ||
| isAddToListBottomSheetOpen = false, | ||
| isShareBottomSheetOpen = false, | ||
| showCreateListBottomSheet = false, | ||
| ) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
extract the content of onSuccess to other function
and put the updateState that at the end in the onEnd block and use for it the call by reference
ElsayedMagdy122
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording.2025-08-20.040333.mp4