Skip to content

feat: name first-apply dose fields on WW-PGD projection rows - #129

Open
quint-mbbdigital wants to merge 1 commit into
CalculatedContent:mainfrom
quint-mbbdigital:pr/ng-c-dose-fields-on-projection-rows
Open

feat: name first-apply dose fields on WW-PGD projection rows#129
quint-mbbdigital wants to merge 1 commit into
CalculatedContent:mainfrom
quint-mbbdigital:pr/ng-c-dose-fields-on-projection-rows

Conversation

@quint-mbbdigital

Copy link
Copy Markdown
Contributor

Type

  • C embeds a definition choice (logging only)
  • A no-def
  • B docs-only

Summary

Every projection row now includes:

  • dose_definition = relative_frobenius_change_applied
  • dose_relative_frobenius (alias of applied relative Frobenius)
  • is_first_projection_event (true when projection_event == 1)

Why

Makes “strength / first-apply dose” readable for matched comparisons without reverse-engineering column meaning. Numeric dose is the same as existing relative_frobenius_change_applied.

Definition surface

  • Choice: dose = relative Frobenius of applied update
  • Default: unchanged dynamics
  • Open to change: first-event heuristic if you prefer per-layer lifetime state

Test plan

  • pytest tests/test_external_wwpgd_pass3.py::test_projection_rows_include_dose_identity_fields
  • no efficacy claim

Out of scope

Dual-label α/q (separate PR), commit pin.

Emit dose_definition, dose_relative_frobenius, and is_first_projection_event
on every projection CSV row. Dose is relative Frobenius change of the applied
update (same numeric as relative_frobenius_change_applied).

Logging-only Class C: no actuator or default change. Enables matched-dose
comparisons without reverse-engineering CSV column meaning.
charlesmartin14 added a commit that referenced this pull request Aug 9, 2026
Replace PR #129's ambiguous first-event flag with exact realized dose fields, zero-based scheduled-event labeling, and per-layer first actual application counts reconstructed from durable scientific projection history. Add old-schema rejection, checkpoint-reconciliation coverage, focused tests, and documentation. No optimizer or projection mathematics change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant