feat: name first-apply dose fields on WW-PGD projection rows - #129
Open
quint-mbbdigital wants to merge 1 commit into
Open
Conversation
Emit dose_definition, dose_relative_frobenius, and is_first_projection_event on every projection CSV row. Dose is relative Frobenius change of the applied update (same numeric as relative_frobenius_change_applied). Logging-only Class C: no actuator or default change. Enables matched-dose comparisons without reverse-engineering CSV column meaning.
charlesmartin14
added a commit
that referenced
this pull request
Aug 9, 2026
Replace PR #129's ambiguous first-event flag with exact realized dose fields, zero-based scheduled-event labeling, and per-layer first actual application counts reconstructed from durable scientific projection history. Add old-schema rejection, checkpoint-reconciliation coverage, focused tests, and documentation. No optimizer or projection mathematics change.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Summary
Every projection row now includes:
dose_definition=relative_frobenius_change_applieddose_relative_frobenius(alias of applied relative Frobenius)is_first_projection_event(true whenprojection_event == 1)Why
Makes “strength / first-apply dose” readable for matched comparisons without reverse-engineering column meaning. Numeric dose is the same as existing
relative_frobenius_change_applied.Definition surface
Test plan
pytest tests/test_external_wwpgd_pass3.py::test_projection_rows_include_dose_identity_fieldsOut of scope
Dual-label α/q (separate PR), commit pin.