Skip to content

feat: optional WWPGD_COMMIT_PIN for floating ww_pgd installs - #130

Closed
quint-mbbdigital wants to merge 1 commit into
CalculatedContent:mainfrom
quint-mbbdigital:pr/ng-c-wwpgd-commit-pin
Closed

feat: optional WWPGD_COMMIT_PIN for floating ww_pgd installs#130
quint-mbbdigital wants to merge 1 commit into
CalculatedContent:mainfrom
quint-mbbdigital:pr/ng-c-wwpgd-commit-pin

Conversation

@quint-mbbdigital

Copy link
Copy Markdown
Contributor

Type

  • C embeds a definition choice (opt-in env)
  • A no-def
  • B docs-only

Summary

Default remains floating ww_pgd install. Optional:

export WWPGD_COMMIT_PIN=<full_or_prefix_sha>

When set, WW-PGD training setup fails if installed VCS commit mismatches (prefix match OK). Docs: docs/WWPGD_COMMIT_PIN.md.

Why

Joint / freeze runs need actuator version fail-loud without changing everyone’s default floating install.

Definition surface

  • Choice: pin only when env set
  • Default: unchanged (floating)
  • Open to change: env name, fail vs warn

Test plan

  • pytest tests/test_wwpgd_commit_pin.py
  • no efficacy claim

Out of scope

Changing default install source or spectral targets.

Default remains unpinned (git main / pyproject floating install).
When WWPGD_COMMIT_PIN is set, WW-PGD training setup fails if the
installed package VCS commit does not match (prefix OK).

Manifest provenance records pin request and resolved commit.
Class C / opt-in: no default or spectral-target change.

Copy link
Copy Markdown
Member

Superseded by #132. The replacement moves verification to the shared WWPGD configuration and candidate boundaries, records truthful verified provenance, rejects unsafe SHA prefixes, covers the root and isolated runners, and passes the complete repository CI suite. Closing this PR without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants