feat(trace_log_tracker): dose/actuator provenance on step stats - #49
Draft
quint-mbbdigital wants to merge 2 commits into
Draft
Conversation
Logging-only fields (actuator_id, ecs_backend, dose_definition, dose_value, is_first_apply) mirror local_delta CalculatedContent#34 grammar: null dose when no correction, schedule-aware first apply. Correction mathematics unchanged. Inventory doc lists remaining packages.
Split schedule clock (is_first_due) from first successful correction per parameter (is_first_apply) so null-dose due steps are not first-apply (F1). Persist applied_parameters in state_dict for resume-safe logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Summary
Extend local_delta #34 provenance grammar to
trace_log_trackerstep stats:actuator_id = trace_log_trackerecs_backend = midpoint_pl_detx(lineage label for joint tables)dose_definition = correction_frobenius_over_base_step_delta_frobenius(matches existingcorrection_ratio)dose_value= that ratio when a correction applied;nullon skipped / geometry_failedis_first_apply= first successful correction per parameter (not first schedule-due step)is_first_due= first schedule-due clock step (may have null dose)Also add
docs/PROVENANCE_INVENTORY.mdlisting which packages emit these fields.Why
Inventory: only
wwpgd_local_deltahad #34-style provenance. Trace-log is the midpoint sibling; joint tables need the same fields under F1–F5.Definition surface (C)
is_first_duevsis_first_apply); F4 null dose on no-op; F5 explicit definition stringPrior / SoT
Test plan
PYTHONPATH=. python -m unittest discover -s tests -vinoptimizers/trace_log_trackerOut of scope
Other optimizers' provenance (see inventory); changing defaults; efficacy claims.