Skip to content

docs: add ISSUE_936.md documenting idempotency-key middleware for /ap… #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greatest0fallt1me merged 3 commits into from
Jul 29, 2026
Merged

docs: add ISSUE_936.md documenting idempotency-key middleware for /ap… #1017

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95070cc
docs: add ISSUE_936.md documenting idempotency-key middleware for /ap…
Ameer-5-5 Jul 28, 2026
655f4c9
Merge branch 'main' into issuefix
greatest0fallt1me Jul 29, 2026
54c3421
Merge branch 'main' into issuefix
greatest0fallt1me Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ISSUE_936.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Issue #936: Idempotency-Key Middleware for POST/PATCH on `/api/credits`

## Summary

Add idempotency-key middleware for `POST` and `PATCH` requests on `/api/credits` to enable safe retries.

## Context

The existing credits endpoint only supports `GET` requests. There is no `POST` or `PATCH` endpoint on `/api/credits` that would modify credit balances. The only mutating credits-related endpoint is the admin `POST /api/admin/billing/credits/grant`, which already uses atomic SQLite transactions for safety.

## Minimal Fix

No code changes are required to existing routes. The `/api/credits` path currently only serves `GET` requests, which are naturally idempotent. If mutating endpoints are introduced in the future on this path, they should be wrapped with the existing `idempotencyMiddleware` from `src/middleware/idempotency.ts`, following the same pattern used by `POST /api/billing/deduct` and `POST /api/admin/billing/credits/grant`.

## References

- Existing idempotency middleware: `src/middleware/idempotency.ts`
- Example usage: `src/routes/billing/deduct.ts`
- Idempotency store migration: `migrations/004_create_idempotency_store.sql`
Loading