feat(gateway): generate and propagate X-Correlation-Id (GrantFox FWC26) - #1018
Merged
greatest0fallt1me merged 3 commits intoJul 29, 2026
Merged
Conversation
- Mount correlationMiddleware on the gateway router so every /api/gateway request resolves an X-Correlation-Id (from client header → req.id → UUID v4) - Forward x-correlation-id alongside x-request-id in all outbound upstream fetch calls so multi-hop request chains are fully traceable - Attach req.correlationId for downstream handlers and structured logging - Set X-Correlation-Id response header so callers can correlate request chains - Declare req.correlationId on Express.Request in express.d.ts - Add focused test suite in gatewayRoutes.test.ts covering: - Response header always present (including 401/402/429 short-circuits) - Client-supplied header echoed exactly - Fallback to X-Request-Id when no correlation header is provided - UUID generated when neither header is present - Outbound upstream headers carry x-correlation-id - Independent propagation of request-id and correlation-id - Oversized header sanitisation (>128 chars falls back to req.id) - Control-character stripping (header injection prevention) - Response/outbound consistency Closes #FWC26
|
@vally111 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged into main via admin resolver (-X theirs). |
Contributor
|
CI passed, solid PR — merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #897