feat(api): Add ETag / 304 caching on /api/maintenance - #1022
Merged
greatest0fallt1me merged 3 commits intoJul 29, 2026
Merged
Conversation
|
@kosisochukwu1234 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
All checks green — merging. Nice job! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #886
This PR addresses the backend issue for the GrantFox FWC26 campaign. It introduces strong ETag generation and HTTP
304 Not Modifiedsupport for the public-facing/api/maintenanceendpoint.Previously, the endpoint returned a full
200 OKresponse along with the payload every time it was polled. With this update, we emit a strong SHA-256 ETag corresponding to the response payload. By honoring theIf-None-Matchheader in subsequent client requests, we cut down bandwidth significantly on repeat reads, meeting the campaign's high-traffic performance needs.Changes Included
etagMiddlewareto thepublicMaintenanceRouterinsrc/routes/maintenance.ts.src/routes/maintenance.tsto document the newETaggeneration and caching behavior, making the API/visible changes clear to other contributors.src/routes/maintenance.test.tsunderdescribe('ETag / 304 caching (issue #021)').ETagis present on first requests.If-None-Matchcorrectly short-circuit and return304 Not Modifiedwith an empty body and stripped content headers.If-None-Matchstrings correctly fall back to a standard200 OKresponse.Security & Reliability