feat(rate-limit): add correlation-id propagation on /api/rate-limit #877 - #1028
Merged
greatest0fallt1me merged 3 commits intoJul 29, 2026
Merged
Conversation
- Create src/routes/rate-limit.ts with correlationMiddleware applied to all sub-routes so every response includes X-Correlation-Id header - Update app.ts to use the new rate-limit router (preserving the same /api/rate-limit/health endpoint path) - Add focused tests covering client echo, UUID generation, sanitization, and health endpoint compatibility Closes CalloraOrg#877
|
@TINEROW Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Green ✅ merging. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds X-Correlation-Id generation and propagation through the
/api/rate-limitroute group, ensuring every response includes a correlation header and downstream handlers have access toreq.correlationIdfor structured logging and outbound call correlation.Related Issue
Closes #877
Changes
src/routes/rate-limit.ts— Main rate-limit router that appliescorrelationMiddleware(fromsrc/middleware/correlation.ts) to all sub-routes before delegating to the health probesrc/app.ts— Updated to mountcreateRateLimitRouterinstead of the bare health router; preserves the same/api/rate-limit/healthendpoint pathsrc/routes/rate-limit/correlation.test.ts— 7 tests covering: response header presence, client-supplied ID echoing, UUID generation fallback, sanitation of oversized IDs, health endpoint compatibility, and header presence in degraded statesVerification Results
resolveCorrelationId()req.idthen fresh UUIDTimeline