add support for MPC extended packed provisional #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
So, despite the rust cargo errors appearing when we upgraded to 1.1.0, it appears that they have followed despite the reversion and now this is failing. Oddly, cargo tests passed before, so I really can't say what's going on here. |
Collaborator
Author
|
OK, I think the problem is that the upstream merge to 1.1.0 deleted the /data/ dir with a bunch of bsp files that were used in testing. I think the tests are assuming those still exist, rather then trying to grab them fresh. Might need to revert further |
annie444
approved these changes
Jul 31, 2025
Collaborator
annie444
left a comment
annie444
left a comment
There was a problem hiding this comment.
This looks good to me! You might want to review my changes, but otherwise I think we're good to go (besides the broken doc tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPC will be introducing a new method of packing provisional designations shortly to support the anticipated Rubin discovery volume. This changes implements their new packing scheme.
Closes #191