Thread safety in with_accessible_by_strategy block#871
Open
NikosVlagoidis wants to merge 2 commits intoCanCanCommunity:developfrom
Open
Thread safety in with_accessible_by_strategy block#871NikosVlagoidis wants to merge 2 commits intoCanCanCommunity:developfrom
NikosVlagoidis wants to merge 2 commits intoCanCanCommunity:developfrom
Conversation
ghiculescu
approved these changes
Oct 25, 2024
Author
|
@ghiculescu Hey sorry for the ping. Is this being merged soon? |
Contributor
|
I'm not a committor on this repo, so it will need someone else to review it. It looks good to me. |
|
@coorasse could you have a look at this by any chance please? |
CJStadler
approved these changes
Jun 4, 2025
CJStadler
left a comment
CJStadler
left a comment
There was a problem hiding this comment.
FWIW I have encountered this bug in a production Rails application running on Puma. It caused a small percentage of requests to fail non-deterministically because the strategy was changed in a different thread.
I've tested that this PR fixes the issue in our application. Thank you @NikosVlagoidis!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from the initial implementation #675
@ghiculescu as we just discussed!