Custom-Legend-Schema development Closes #2363 #3144

HansAlainNyaba · 2025-11-24T14:59:26Z

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Add the URL for your deploy!
https://hansalainnyaba.github.io/geoview/demos-navigator.html?config=./configs/navigator/demos/17-package-custom-legend.json

Checklist:

I have build (rush build) and deploy (rush host) my PR
I have connected the issues(s) to this PR
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have created new issue(s) related to the outcome of this PR is needed
~~I have made corresponding changes to the documentation~~
~~I have added tests that prove my fix is effective or that my feature works~~
~~New and existing unit tests pass locally with my changes~~

This change is

…2363

…legend4

jolevesq

@jolevesq reviewed 5 of 7 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @HansAlainNyaba)

packages/geoview-custom-legend/src/custom-legend-style.ts line 9 at r2 (raw file):

 * @returns {SxClasses} An object containing the style classes
 */
export const getSxClassesMain = (): SxClasses => ({

Same comment as above

packages/geoview-custom-legend/src/custom-legend.tsx line 28 at r2 (raw file):

  const { cgpv } = window as TypeWindow;
  const { ui, reactUtilities } = cgpv;
  const { useState } = reactUtilities.react;

Why are you using useState?

packages/geoview-custom-legend/src/custom-legend.tsx line 33 at r2 (raw file):

  const theme = ui.useTheme();
  const sxClasses = getSxClasses(theme);
  const legendSxMain = getSxClassesMain();

Regroup all scClasses in one

packages/geoview-custom-legend/tsconfig.json line 10 at r2 (raw file):

  },
  "include": ["src"],
  "references": [{ "path": "../geoview-core" }]

Bring bac spaces

packages/geoview-custom-legend/schema.json line 29 at r2 (raw file):

  },
  "definitions": {
    "legendItem": {

Looks like we miss some properties fromt he RAMP custom legend config

packages/geoview-custom-legend/src/index.tsx line 65 at r2 (raw file):

    return {
      id: `custom-legend`,
      tooltip: 'CustomLegend.title',

we need to provide aria-label, if not the same you can add tooltip

HansAlainNyaba

Reviewable status: 5 of 9 files reviewed, 6 unresolved discussions (waiting on @jolevesq)

packages/geoview-custom-legend/schema.json line 29 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Looks like we miss some properties fromt he RAMP custom legend config

Done.

packages/geoview-custom-legend/src/custom-legend.tsx line 28 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Why are you using useState?

Done.

jolevesq

@jolevesq reviewed 2 of 4 files at r3, all commit messages.
Reviewable status: 7 of 9 files reviewed, 6 unresolved discussions (waiting on @HansAlainNyaba)

packages/geoview-custom-legend/schema.json line 108 at r3 (raw file):

            "description": "ID of the layer this legend item is associated with (if any)"
          },
          "filter": {

What is this?

HansAlainNyaba · 2025-12-19T13:53:42Z

packages/geoview-custom-legend/schema.json line 29 at r2 (raw file):

Previously, HansAlainNyaba (Hans A ) wrote…

Done.

I added most of them we now have ENTRY, ENTRY GROUP, INFO SECTION, UNBOUND LAYER and VISIBILITY SET in the schema

…legend4

HansAlainNyaba

@HansAlainNyaba made 4 comments.
Reviewable status: 3 of 9 files reviewed, 6 unresolved discussions (waiting on @jolevesq).

packages/geoview-custom-legend/schema.json line 108 at r3 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

What is this?

I removed the filter property

packages/geoview-custom-legend/src/custom-legend.tsx line 33 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Regroup all scClasses in one

Done.

packages/geoview-custom-legend/src/custom-legend-style.ts line 9 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Same comment as above

Done.

packages/geoview-custom-legend/src/index.tsx line 65 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

we need to provide aria-label, if not the same you can add tooltip

Done.

HansAlainNyaba · 2025-12-19T16:17:36Z

packages/geoview-custom-legend/tsconfig.json line 10 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Bring bac spaces

?? I dont understand this

jolevesq

@jolevesq reviewed 2 files and all commit messages, made 6 comments, and resolved 3 discussions.
Reviewable status: 5 of 9 files reviewed, 7 unresolved discussions (waiting on @HansAlainNyaba).

packages/geoview-custom-legend/tsconfig.json line 10 at r2 (raw file):

Previously, HansAlainNyaba (Hans A ) wrote…

?? I dont understand this

[ { not [{

packages/geoview-custom-legend/src/index.tsx line 65 at r2 (raw file):

Previously, HansAlainNyaba (Hans A ) wrote…

Done.

When the same, not needed to set toltip

packages/geoview-custom-legend/schema.json line 7 at r5 (raw file):

  "type": "object",
  "properties": {
    "id": {

This is not needed

packages/geoview-custom-legend/schema.json line 11 at r5 (raw file):

      "description": "Unique identifier for the legend component"
    },
    "enabled": {

Will not be needed, if package there, it is enable

packages/geoview-custom-legend/schema.json line 112 at r5 (raw file):

      }
    },
    "display": {

Not a good object, not needed + all children elements

packages/geoview-custom-legend/schema.json line 176 at r5 (raw file):

      "description": "Schema version"
    },
    "entry": {

This is suppose to be child of legendItemLIst... what you already ahev in legend item list is a sub type of one of this... Look at how RAMP is done

…legend4

HansAlainNyaba · 2026-01-07T16:14:25Z

packages/geoview-custom-legend/schema.json line 112 at r5 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Not a good object, not needed + all children elements

OOK I removed "display" item

HansAlainNyaba · 2026-01-07T21:09:24Z

packages/geoview-custom-legend/schema.json line 176 at r5 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

This is suppose to be child of legendItemLIst... what you already ahev in legend item list is a sub type of one of this... Look at how RAMP is done

`

HansAlainNyaba · 2026-01-07T21:10:40Z

packages/geoview-custom-legend/src/index.tsx line 65 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

When the same, not needed to set toltip

Done.

…legend4

…ba/geoview into 2363-custom-legend4

HansAlainNyaba

@HansAlainNyaba made 6 comments.
Reviewable status: 3 of 9 files reviewed, 7 unresolved discussions (waiting on @jolevesq).

packages/geoview-custom-legend/schema.json line 7 at r5 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

This is not needed

Done.

packages/geoview-custom-legend/schema.json line 11 at r5 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Will not be needed, if package there, it is enable

Done.

packages/geoview-custom-legend/schema.json line 112 at r5 (raw file):

Previously, HansAlainNyaba (Hans A ) wrote…

OOK I removed "display" item

Done

packages/geoview-custom-legend/schema.json line 176 at r5 (raw file):

Previously, HansAlainNyaba (Hans A ) wrote…

`

We have entry in ramp

packages/geoview-custom-legend/tsconfig.json line 10 at r2 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

[ { not [{

Done.

packages/geoview-custom-legend/src/index.tsx line 65 at r2 (raw file):

Previously, HansAlainNyaba (Hans A ) wrote…

Done.

What need to be the same? tooltip == "aria-label" I dont understand

jolevesq

@jolevesq reviewed 3 files and all commit messages, made 4 comments, and resolved 6 discussions.
Reviewable status: 6 of 9 files reviewed, 4 unresolved discussions (waiting on @HansAlainNyaba).

packages/geoview-custom-legend/schema.json line 176 at r5 (raw file):

Previously, HansAlainNyaba (Hans A ) wrote…

We have entry in ramp

Yes but need to be a child on legendList. In your PR it is totally disconnected from the array of element

packages/geoview-custom-legend/src/custom-legend.tsx line 20 at r6 (raw file):

}

interface FilterConfig {

What is this for?

packages/geoview-custom-legend/src/custom-legend.tsx line 35 at r6 (raw file):

  visible?: boolean;
  layerId?: string;
  filter?: FilterConfig;

This is not use...

packages/geoview-custom-legend/src/custom-legend-style.ts line 10 at r6 (raw file):

 */
export const getSxClasses = <T extends Record<string, unknown>>(theme: T): SxClasses => {
  const typedTheme = theme as unknown as {

Theme is in the core... you are not able to reuse?

…legend4

HansAlainNyaba

@HansAlainNyaba made 4 comments.
Reviewable status: 4 of 9 files reviewed, 4 unresolved discussions (waiting on @jolevesq).

packages/geoview-custom-legend/schema.json line 176 at r5 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Yes but need to be a child on legendList. In your PR it is totally disconnected from the array of element

Done.

packages/geoview-custom-legend/src/custom-legend.tsx line 20 at r6 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

What is this for?

copilot garbage.. will remove it

packages/geoview-custom-legend/src/custom-legend.tsx line 35 at r6 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

This is not use...

Done.

packages/geoview-custom-legend/src/custom-legend-style.ts line 10 at r6 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Theme is in the core... you are not able to reuse?

another complication from copilot will do different

…legend4

HansAlainNyaba

@HansAlainNyaba made 1 comment.
Reviewable status: 4 of 9 files reviewed, 4 unresolved discussions (waiting on @jolevesq).

packages/geoview-custom-legend/schema.json line 176 at r5 (raw file):

Previously, HansAlainNyaba (Hans A ) wrote…

Done.

the entry is now under legendlist

HansAlainNyaba added 2 commits November 24, 2025 09:54

Custom-Legend-Schema development Closes Canadian-Geospatial-Platform#…

3cbbfa6

…2363

Merge branch 'Canadian-Geospatial-Platform:develop' into 2363-custom-…

f1c0e3f

…legend4

HansAlainNyaba force-pushed the 2363-custom-legend4 branch from 1b99479 to f1c0e3f Compare November 28, 2025 14:16

jolevesq requested changes Dec 15, 2025

View reviewed changes

Merge branch 'develop' into 2363-custom-legend4

6e7dd82

HansAlainNyaba force-pushed the 2363-custom-legend4 branch from dd075b4 to 6e7dd82 Compare December 17, 2025 05:16

HansAlainNyaba requested a review from jolevesq December 17, 2025 05:20

HansAlainNyaba commented Dec 17, 2025

View reviewed changes

jolevesq requested changes Dec 17, 2025

View reviewed changes

HansAlainNyaba force-pushed the 2363-custom-legend4 branch from 60ac68d to 75d2417 Compare December 19, 2025 13:48

HansAlainNyaba force-pushed the 2363-custom-legend4 branch from 75d2417 to f6e5c29 Compare December 19, 2025 14:59

Merge branch 'Canadian-Geospatial-Platform:develop' into 2363-custom-…

849401e

…legend4

HansAlainNyaba force-pushed the 2363-custom-legend4 branch from f6e5c29 to 849401e Compare December 19, 2025 16:13

HansAlainNyaba requested a review from jolevesq December 19, 2025 16:16

HansAlainNyaba commented Dec 19, 2025

View reviewed changes

jolevesq requested changes Dec 19, 2025

View reviewed changes

Merge branch 'Canadian-Geospatial-Platform:develop' into 2363-custom-…

12d1c33

…legend4

HansAlainNyaba added 2 commits January 7, 2026 16:45

Merge branch 'Canadian-Geospatial-Platform:develop' into 2363-custom-…

3de4cd6

…legend4

Merge branch '2363-custom-legend4' of https://github.com/HansAlainNya…

86b1ea0

…ba/geoview into 2363-custom-legend4

HansAlainNyaba requested a review from jolevesq January 7, 2026 21:54

HansAlainNyaba commented Jan 7, 2026

View reviewed changes

jolevesq requested changes Jan 8, 2026

View reviewed changes

Merge branch 'Canadian-Geospatial-Platform:develop' into 2363-custom-…

7d8efc7

…legend4

HansAlainNyaba force-pushed the 2363-custom-legend4 branch 2 times, most recently from 6a45729 to e22eee4 Compare January 14, 2026 22:32

HansAlainNyaba requested a review from jolevesq January 14, 2026 22:35

HansAlainNyaba commented Jan 14, 2026

View reviewed changes

Merge branch 'Canadian-Geospatial-Platform:develop' into 2363-custom-…

4eca7ba

…legend4

HansAlainNyaba force-pushed the 2363-custom-legend4 branch from e22eee4 to 4eca7ba Compare January 15, 2026 17:24

Update schema.json

1d196ff

HansAlainNyaba commented Jan 15, 2026

View reviewed changes

Custom-Legend-Schema development Closes #2363 #3144

Are you sure you want to change the base?

Custom-Legend-Schema development Closes #2363 #3144

Uh oh!

Conversation

HansAlainNyaba commented Nov 24, 2025 • edited by jolevesq Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

jolevesq left a comment

Choose a reason for hiding this comment

Uh oh!

HansAlainNyaba left a comment

Choose a reason for hiding this comment

Uh oh!

jolevesq left a comment

Choose a reason for hiding this comment

Uh oh!

HansAlainNyaba commented Dec 19, 2025

Uh oh!

HansAlainNyaba left a comment

Choose a reason for hiding this comment

Uh oh!

HansAlainNyaba commented Dec 19, 2025

Uh oh!

jolevesq left a comment

Choose a reason for hiding this comment

Uh oh!

HansAlainNyaba commented Jan 7, 2026

Uh oh!

HansAlainNyaba commented Jan 7, 2026

Uh oh!

HansAlainNyaba commented Jan 7, 2026

Uh oh!

HansAlainNyaba left a comment

Choose a reason for hiding this comment

Uh oh!

jolevesq left a comment

Choose a reason for hiding this comment

Uh oh!

HansAlainNyaba left a comment

Choose a reason for hiding this comment

Uh oh!

HansAlainNyaba left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HansAlainNyaba commented Nov 24, 2025 •

edited by jolevesq

Loading