-
Notifications
You must be signed in to change notification settings - Fork 40
feat(renderer): Incorporate visual variables into the geoview renderer #3253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(renderer): Incorporate visual variables into the geoview renderer #3253
Conversation
jolevesq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jolevesq reviewed 6 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @MatthewMuehlhauserNRCan and @StatIct).
packages/geoview-core/src/geo/utils/renderer/geoview-renderer.ts line 1320 at r1 (raw file):
* @returns {number} The interpolated output value. */ static interpolateValue(value: number, value1: number, value2: number, output1: number, output2: number): number {
Is does functions private to the class?
Add @StatIct for JSDOC
packages/geoview-core/src/geo/utils/renderer/geoview-renderer.ts line 1352 at r1 (raw file):
const g = Math.max(0, Math.min(255, color[1])); const b = Math.max(0, Math.min(255, color[2])); // Alpha is optional, defaults to 255 (fully opaque), convert to 0-1 range
Try to add empty line before a comment line for readability. Ok not to have as first comment of a if but nice for after { between const or function call
MatthewMuehlhauserNRCan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatthewMuehlhauserNRCan made 5 comments and resolved 3 discussions.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @jolevesq and @StatIct).
packages/geoview-core/src/geo/utils/renderer/geoview-renderer.ts line 1320 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Is does functions private to the class?
Add @StatIct for JSDOC
Done
packages/geoview-core/src/geo/utils/renderer/geoview-renderer.ts line 1352 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Try to add empty line before a comment line for readability. Ok not to have as first comment of a if but nice for after { between const or function call
Done
MatthewMuehlhauserNRCan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatthewMuehlhauserNRCan made 1 comment and resolved 1 discussion.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @jolevesq and @StatIct).
Alex-NRCan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alex-NRCan reviewed 6 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jolevesq and @StatIct).
jolevesq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jolevesq partially reviewed 1 file and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MatthewMuehlhauserNRCan).
jolevesq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jolevesq reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MatthewMuehlhauserNRCan).
9d6a1ea
into
Canadian-Geospatial-Platform:develop
Description
Some ESRI feature services have visualVariables that can alter feature's symbol based on a field value. This now incorporates this type of styling.
Fixes #3233
Type of change
How Has This Been Tested?
Host updated @ 2026-01-15 4:55 PM
Created a navigator page that pulls in a FeatureService which has a rotation applied by a visual variable. Also created a layer and manually set visual variables for color, size, and opacity to make sure they are working. Example services are hard to find, so may still require some adjustments.
Visual Variable navigator page
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is