#17 A dead-lettered command gets a terminal processing_failed first, so Watcher isn't left waiting - #19
Merged
Conversation
…the DLQ, once, never after its own fact Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…raction_error first Watcher's reaper now re-issues only while other facts flow (watcher#325), so a command dead-lettered with no fact would sit in flight, and Watcher's health would read a quiet Processor as down. At the cap the consumer publishes processing_failed (terminal, extraction_error, detail 'dead-lettered: …'): - skipped when this entry's fact already went out (a refused ack, or a retried dead-letter); - a transient refusal leaves the entry pending; - a non-transient refusal is logged and the entry is dead-lettered anyway. Spec §4 and DEPLOYMENT.md are amended. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed, skipped or refused An operator triaging the DLQ can now tell from the journal whether Watcher was told. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… extraction_error, detail capped, refusals raised Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fact Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gregoryfoster
force-pushed
the
17-dlq-terminal-fact
branch
from
October 2, 2026 21:05
9c44102 to
6e518d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17. Refs #1, CannObserv/watcher#325.
Why. Watcher's reaper now re-issues only while other
content.derivedfacts flow (watcher#325, issuecomment-5958475061). A command Processor dead-letters at the escape cap used to get no fact. It would sit in flight, and Watcher's 'Processor not consuming' signal would fire against a healthy Processor in any quiet period.What. At the cap, before dead-lettering a decodable command, the consumer publishes
processing_failedwithterminal=true,reason=extraction_error, anddetail=dead-lettered: gave up on attempt 3: …(handler.publish_gave_up).Consumer._fact_outand cleared on ack, dead-letter, or a deleted reclaim.failure fact refused) and the entry is dead-lettered anyway.Tests (red first,
c2ec537):Full suite: 235 passed.
Conflicts: #18 also edits spec §4 (a different bullet). Whichever ships second gets rebased.
🤖 Generated with Claude Code