Skip to content

fix(redshift): use public strip_trailing_semicolon on unlimited path#2560

Merged
goldmedal merged 1 commit into
Canner:mainfrom
Bartok9:fix/redshift-strip-trailing-semicolon-import
Jul 24, 2026
Merged

fix(redshift): use public strip_trailing_semicolon on unlimited path#2560
goldmedal merged 1 commit into
Canner:mainfrom
Bartok9:fix/redshift-strip-trailing-semicolon-import

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Diff is one call-site rename
  • Wren SDK CI lint + unit tests green

Summary by CodeRabbit

  • Bug Fixes
    • Improved Redshift query handling by removing trailing semicolons when retrieving unlimited results.
    • Preserved existing query limits and execution behavior.

Canner#2482 left a private _strip_trailing_semicolon call after the shared
helper rename, which breaks ruff F821 and unit tests on main merge refs.
@github-actions github-actions Bot added python Pull requests that update Python code core labels Jul 22, 2026
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 65d73b7d-4a1d-4fb3-978b-babca9d3ff4c

📥 Commits

Reviewing files that changed from the base of the PR and between f4b45ed and b912e5d.

📒 Files selected for processing (1)
  • core/wren/src/wren/connector/redshift.py

Walkthrough

The Redshift connector’s unlimited-results query path now uses the shared strip_trailing_semicolon helper instead of the private helper. Cursor execution, limit handling, and result construction remain unchanged.

Changes

Redshift SQL normalization

Layer / File(s) Summary
Unlimited query preprocessing
core/wren/src/wren/connector/redshift.py
The unlimited query path calls the shared strip_trailing_semicolon helper before execution.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

  • Canner/WrenAI issue 2497 — Covers routing Redshift unlimited queries through the shared semicolon-stripping helper.
  • Canner/WrenAI issue 2498 — Tracks shared trailing-semicolon handling across connectors.

Possibly related PRs

Suggested reviewers: goldmedal

Poem

A rabbit hopped through SQL bright,
And trimmed one semicolon right.
The shared helper led the way,
While cursors kept their usual play.
Redshift rows arrived just right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the Redshift unlimited-path helper fix and is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@goldmedal
goldmedal merged commit 50e710d into Canner:main Jul 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants