fix(redshift): use public strip_trailing_semicolon on unlimited path#2560
Conversation
Canner#2482 left a private _strip_trailing_semicolon call after the shared helper rename, which breaks ruff F821 and unit tests on main merge refs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Redshift connector’s unlimited-results query path now uses the shared ChangesRedshift SQL normalization
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
sql = _strip_trailing_semicolon(sql)on the unlimited query path while the import is the publicstrip_trailing_semicolonfromwren.connector.base.test_query_without_limit_strips_trailing_semicolon, and poisoned merge CI on open PRs (e.g. fix(mssql): strip trailing semicolons before sqlglot LIMIT rewrite #2476).Test plan
Summary by CodeRabbit