Skip to content

Conversation

@WcaleNieWolny
Copy link
Contributor

@WcaleNieWolny WcaleNieWolny commented Jan 9, 2026

Summary

  • Fixed the --build-mode CLI option being silently ignored
  • The option was defined but never included in the API request payload
  • Now --build-mode debug actually creates debug builds instead of defaulting to release

Test plan

  • Run npx @capgo/cli build request --platform ios --build-mode debug and verify the backend receives build_mode: "debug"
  • Run without --build-mode flag and verify it defaults to release

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added support for specifying build mode (debug or release) when creating native builds.

✏️ Tip: You can customize this high-level summary in your review settings.

The --build-mode CLI option was defined but never included in the
request payload sent to the backend. This caused the option to be
silently ignored, with all builds defaulting to 'release' mode.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2026

📝 Walkthrough

Walkthrough

An optional build_mode field is added to the native build request payload, mapping from options.buildMode. This augments the request structure without modifying control flow or error handling.

Changes

Cohort / File(s) Summary
Build Request Configuration
src/build/request.ts
Adds optional build_mode field to request payload and maps it from options.buildMode to support explicit build mode specification (debug or release).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 With whiskers twitching, what's this I see?
A build\_mode field, both debug and free!
From options it springs, so light and so bright,
One tiny addition makes everything right. 🏗️✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding build_mode to the backend request in the build functionality.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbe1e8c and ac78dc8.

📒 Files selected for processing (1)
  • src/build/request.ts
🧰 Additional context used
🧬 Code graph analysis (1)
src/build/request.ts (1)
src/sdk.ts (1)
  • BuildCredentials (1785-1785)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: check-posix-paths-windows (windows-2025)
  • GitHub Check: Run tests
🔇 Additional comments (1)
src/build/request.ts (1)

598-607: LGTM! Clean fix for the missing build_mode field.

The implementation correctly maps options.buildMode to the build_mode field in the request payload. The optional typing is appropriate—when undefined, JSON serialization will omit the field entirely, allowing the backend to apply its default value ("release").

The naming convention (snake_case for API fields, camelCase for TypeScript) is consistent with the existing pattern used for app_id and other fields. Type safety is enforced at compile time, ensuring only valid values ("debug" or "release") can be assigned.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@riderx riderx merged commit 9f6a29d into main Jan 9, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants