Skip to content

chore: sync upstream PR #8473 - fix(runtime): plugin proxy must not be unintentionally Thenable #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cursor merged 10 commits into from
Aug 13, 2026
Merged

chore: sync upstream PR #8473 - fix(runtime): plugin proxy must not be unintentionally Thenable #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
23ad7f8
Release 8.3.2
May 7, 2026
b2d7719
fix(cli): copy plugin files in CocoaPods projects (#8467)
jcesarmobile May 8, 2026
76ff70e
Release 8.3.3
May 8, 2026
b7e167b
chore(cli): update telemetry endpoint (#8464)
alexgerardojacinto May 12, 2026
de1e506
Release 8.3.4
May 12, 2026
c2e4246
fix(runtime): plugin proxy must not be unintentionally Thenable Fixes…
playopsstudio May 17, 2026
aafcc2d
chore: sync upstream PR #8473 from @playopsstudio (upstream-preferred…
Jul 14, 2026
6331af8
chore: rebase onto current plus
cursoragent Aug 13, 2026
0a000fe
fix(runtime): plugin proxy must not be unintentionally Thenable Fixes…
playopsstudio May 17, 2026
7fba2c4
style: apply repository formatter
cursoragent Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,11 @@ export const createCapacitor = (win: WindowCapacitor): CapacitorInstance => {
return pluginHeader ? addListenerNative : addListener;
case 'removeListener':
return removeListener;
// Promise-machinery short-circuit. See #8472 for failure modes.
case 'then':
case 'catch':
case 'finally':
Comment on lines +177 to +179

@cubic-dev-ai cubic-dev-ai Bot Aug 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: When a plugin defines a method named catch or finally, the proxy now returns undefined instead of the method wrapper, so the method is inaccessible for both JS and native implementations. Promise assimilation only reads then; keep only the then case so arbitrary plugin method names remain supported.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At core/src/runtime.ts, line 177:

<comment>When a plugin defines a method named `catch` or `finally`, the proxy now returns `undefined` instead of the method wrapper, so the method is inaccessible for both JS and native implementations. Promise assimilation only reads `then`; keep only the `then` case so arbitrary plugin method names remain supported.</comment>

<file context>
@@ -173,6 +173,11 @@ export const createCapacitor = (win: WindowCapacitor): CapacitorInstance => {
             case 'removeListener':
               return removeListener;
+            // Promise-machinery short-circuit. See #8472 for failure modes.
+            case 'then':
+            case 'catch':
+            case 'finally':
</file context>
Suggested change
case 'then':
case 'catch':
case 'finally':
case 'then':

return undefined;
default:
return createPluginMethodWrapper(prop);
}
Expand Down
17 changes: 17 additions & 0 deletions core/src/tests/plugin.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,23 @@ describe('plugin', () => {
],
});
};

it('plugin proxy must not be a Thenable (Promise.resolve chaining short-circuit)', async () => {
// Web platform; no native bridge headers. registerPlugin returns a Proxy
// that wraps method dispatch. The proxy MUST NOT be unintentionally Thenable
// — otherwise Promise.resolve(proxy) and `await proxy` invoke proxy.then(...)
// and dispatch a bogus "then" method to the native bridge (or web stub).
// See GH issue #8472 for the production failure modes that motivated this regression test.
cap = initCapacitorGlobal(win);
const Awesome = cap.registerPlugin('Awesome');

expect(typeof (Awesome as unknown as { then?: unknown }).then).toBe('undefined');
expect(typeof (Awesome as unknown as { catch?: unknown }).catch).toBe('undefined');
expect(typeof (Awesome as unknown as { finally?: unknown }).finally).toBe('undefined');

const resolved = await Promise.resolve(Awesome);
expect(resolved).toBe(Awesome);
});
});

interface AwesomePlugin extends Plugin {
Expand Down
Loading