Fix manifest comparison translations #1454
Conversation
📝 WalkthroughWalkthroughMultilingual localization updates across 14 language files (German, Spanish, French, Hindi, Indonesian, Italian, Japanese, Korean, Polish, Portuguese, Russian, Turkish, Vietnamese, and Simplified Chinese) adding translations for manifest-related UI labels, platform-specific text, demo placeholders, and API key labels. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@messages/es.json`:
- Line 1307: The value for the localization key "session_key" is hard to read as
"ClaveDeSesionIv"; update the translation for the "session_key" entry to use
proper spacing and casing (e.g., "Clave de sesión IV" or "Clave de Sesión IV"
depending on your project casing convention) so the UI label is clear and the IV
acronym remains uppercase; modify the value associated with the "session_key"
symbol in messages/es.json accordingly.
In `@messages/pt-br.json`:
- Line 287: The PT-BR translation for the key "bundle-link" is inconsistent;
change its value from "Link do bundle" to use "pacote" like other keys (e.g.,
"Link do pacote") so it matches the existing translations such as "bundle" and
"bundle-not-found"; update the string for the "bundle-link" key accordingly.
In `@messages/vi.json`:
- Line 1307: The translation value for the JSON key "session_key" uses lowercase
"Iv"; update the string value to use uppercase "IV" (e.g., change "Khóa phiên
Iv" to "Khóa phiên IV") so the acronym for initialization vector is consistently
cased across the locale file messages/vi.json by editing the value for the
"session_key" entry.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
messages/de.jsonmessages/es.jsonmessages/fr.jsonmessages/hi.jsonmessages/id.jsonmessages/it.jsonmessages/ja.jsonmessages/ko.jsonmessages/pl.jsonmessages/pt-br.jsonmessages/ru.jsonmessages/tr.jsonmessages/vi.jsonmessages/zh-cn.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run tests
🔇 Additional comments (70)
messages/ru.json (4)
867-867: LGTM — placeholder kept intact.The
{hours}token is preserved, so interpolation should work as expected.
898-907: Manifest translations look solid.All placeholders are retained and the phrasing matches the manifest comparison intent.
1056-1056: LGTM.Translation aligns with the “open in new tab” behavior.
1307-1307: LGTM — consistent label localization.Keeps the
Ivprefix while localizing the label.messages/zh-cn.json (5)
423-423: LGTM — clear platform label.Concisely conveys iOS + Android.
898-907: Manifest strings look good.Placeholders are preserved and the copy is consistent across the block.
1056-1056: LGTM.Matches the intended “open in new tab” action.
1468-1468: LGTM.Concise label for the Webhook section.
1486-1486: LGTM — API key label reads well.messages/pl.json (4)
891-891: LGTM — semver level translation is clear.
898-907: Manifest translations look good.Placeholder tokens are preserved across the block.
931-931: LGTM — placeholder retained.
{minutes}is intact and the short format is clear.
1056-1056: LGTM.The translation matches the expected action label.
messages/it.json (8)
423-423: Platform label localized cleanly.
433-433: Checksum label translation is clear.
898-907: Manifest comparison copy looks consistent and placeholders are preserved.
931-931: Short minutes format is localized appropriately.
936-936: Month unit translation looks good.
1056-1056: External tab label reads naturally in Italian.
1307-1307: Session key label localized consistently.
1486-1486: API key label localized clearly.messages/fr.json (7)
423-423: Platform label localized appropriately.
662-664: Demo placeholders are localized consistently.
898-907: Manifest comparison block is well localized and keeps placeholders intact.
931-931: Short minutes format matches French conventions.
936-936: Month unit translation is correct.
1056-1056: External tab label is clear and consistent.
1486-1486: API key label translated cleanly.messages/de.json (8)
423-423: Platform label localized appropriately.
662-662: Demo first-name placeholder localized consistently.
802-802: GitHub stars trend label translation looks good.
898-907: Manifest comparison strings are consistent and keep placeholders intact.
931-931: Short minutes format is correct for German.
936-936: Month abbreviation localized cleanly.
1056-1056: External tab label translation is clear.
1486-1486: API key label localized appropriately.messages/es.json (3)
897-907: LGTM — manifest strings are consistent and placeholders preserved.
931-931: LGTM — concise minute shorthand.
1056-1056: LGTM — external tab label reads naturally.messages/vi.json (5)
423-423: LGTM — platform label reads clearly.
662-662: LGTM — localized placeholder is appropriate.
897-907: LGTM — manifest translations are complete and consistent.
1056-1056: LGTM — external tab label is clear.
1468-1468: LGTM — label is concise and acceptable in Vietnamese.messages/id.json (9)
423-423: LGTM — platform label reads naturally in Indonesian.
662-662: LGTM — localized placeholder fits the demo context.
768-768: LGTM — “Peristiwa” is a good localization for “event.”
846-846: LGTM — role label is clear.
867-867: LGTM — placeholder and phrasing are correct.
897-907: LGTM — manifest strings are fully localized and consistent.
931-931: LGTM — minute shorthand is clear.
936-936: LGTM — month abbreviation is appropriate.
1056-1056: LGTM — “Buka di tab baru” is clear and user-friendly.messages/hi.json (3)
898-907: Manifest comparison strings look consistent and placeholders are preserved.
1056-1056: "Open in new tab" localization looks good.
1307-1307: Confirm whethersession_keyis meant to be a literal token label.If users must copy an exact header/field name, consider keeping the canonical “IvSessionKey” unlocalized across locales; otherwise this translation is fine.
messages/ko.json (6)
423-423: Platform label update is clear.
867-867: Relative time label looks consistent with existing style.
898-907: Manifest comparison strings are localized consistently with placeholders intact.
1056-1056: "Open in new tab" localization looks good.
1307-1307:session_keylabel localization matches the new locale pattern.
1486-1486: API key label localization looks fine.messages/tr.json (4)
423-423: Platform label update is clear and natural.
662-662: Demo first-name placeholder localization looks appropriate.
898-907: Manifest comparison strings are localized consistently with placeholders intact.
1056-1056: "Open in new tab" localization looks good.messages/pt-br.json (2)
898-907: Manifest comparison translations look solid.
423-423: LGTM for the remaining PT-BR label updates.Also applies to: 458-458, 664-664, 891-891, 931-931, 936-936, 1056-1056, 1486-1486
messages/ja.json (2)
898-907: Manifest comparison translations look good.
423-423: LGTM for the remaining JA label updates.Also applies to: 867-867, 1056-1056, 1307-1307, 1486-1486
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| "send-invitation": "Enviar invitación", | ||
| "sending-invitation": "Enviando...", | ||
| "session_key": "IvSessionKey", | ||
| "session_key": "ClaveDeSesionIv", |
There was a problem hiding this comment.
Add spacing/casing for readability in session_key.
“ClaveDeSesionIv” reads like a concatenated token; if this is a UI label, adding spaces and keeping the IV acronym improves clarity.
✏️ Suggested tweak
- "session_key": "ClaveDeSesionIv",
+ "session_key": "Clave de sesión IV",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "session_key": "ClaveDeSesionIv", | |
| "session_key": "Clave de sesión IV", |
🤖 Prompt for AI Agents
In `@messages/es.json` at line 1307, The value for the localization key
"session_key" is hard to read as "ClaveDeSesionIv"; update the translation for
the "session_key" entry to use proper spacing and casing (e.g., "Clave de sesión
IV" or "Clave de Sesión IV" depending on your project casing convention) so the
UI label is clear and the IV acronym remains uppercase; modify the value
associated with the "session_key" symbol in messages/es.json accordingly.
| "bundle-deployed": "Bundle implantado", | ||
| "bundle-is-linked-device": "O pacote está vinculado ao dispositivo, desvincule-o primeiro.", | ||
| "bundle-link": "Link", | ||
| "bundle-link": "Link do bundle", |
There was a problem hiding this comment.
Use “pacote” for consistency with the rest of PT-BR strings.
Most PT-BR strings translate “bundle” as “pacote” (e.g., “bundle”, “bundle-not-found”), so “Link do bundle” stands out as inconsistent.
💡 Suggested fix
- "bundle-link": "Link do bundle",
+ "bundle-link": "Link do pacote",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "bundle-link": "Link do bundle", | |
| "bundle-link": "Link do pacote", |
🤖 Prompt for AI Agents
In `@messages/pt-br.json` at line 287, The PT-BR translation for the key
"bundle-link" is inconsistent; change its value from "Link do bundle" to use
"pacote" like other keys (e.g., "Link do pacote") so it matches the existing
translations such as "bundle" and "bundle-not-found"; update the string for the
"bundle-link" key accordingly.
| "send-invitation": "Gửi lời mời", | ||
| "sending-invitation": "Đang gửi...", | ||
| "session_key": "IvSessionKey", | ||
| "session_key": "Khóa phiên Iv", |
There was a problem hiding this comment.
Confirm IV acronym casing in session_key.
If this refers to “IV” (initialization vector), consider keeping it uppercase for consistency.
✏️ Suggested tweak
- "session_key": "Khóa phiên Iv",
+ "session_key": "Khóa phiên IV",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "session_key": "Khóa phiên Iv", | |
| "session_key": "Khóa phiên IV", |
🤖 Prompt for AI Agents
In `@messages/vi.json` at line 1307, The translation value for the JSON key
"session_key" uses lowercase "Iv"; update the string value to use uppercase "IV"
(e.g., change "Khóa phiên Iv" to "Khóa phiên IV") so the acronym for
initialization vector is consistently cased across the locale file
messages/vi.json by editing the value for the "session_key" entry.
|
Summary (AI generated)
Test plan (AI generated)
Screenshots (AI generated)
Checklist (AI generated)
.
accordingly.
my tests
Generated with AI
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.