fix: validate segment continuity before recovery dispatch

Author: richiemcilroy

apps/web/__tests__/unit/desktop-segments-recovery.test.ts

@@ -120,6 +120,28 @@ beforeEach(() => {
 });
 
 describe("committed source recovery", () => {
+	it.each([
+		{ video_segments: [2, 3] },
+		{ video_segments: [1, 3] },
+		{ audio_init_uploaded: true, audio_segments: [] },
+		{ audio_init_uploaded: false, audio_segments: [1] },
+		{ audio_init_uploaded: true, audio_segments: [1, 3] },
+	])(
+		"does not queue a completed manifest with missing source declarations: %j",
+		async (invalid) => {
+			mocks.get.mockReturnValue(
+				Effect.succeed(
+					Option.some(JSON.stringify({ ...manifest, ...invalid })),
+				),
+			);
+			expect(
+				await completeDesktopSegmentsManifestAndQueue({ videoId, userId }),
+			).toEqual({ status: "source-incomplete" });
+			expect(mocks.queue).not.toHaveBeenCalled();
+			expect(mocks.put).not.toHaveBeenCalled();
+		},
+	);
+
 	it("never marks an inactive but unfinished manifest complete", async () => {
 		const incomplete = { ...manifest, is_complete: false };
 		mocks.get.mockReturnValue(

apps/web/lib/desktop-segments-recovery.ts

@@ -25,6 +25,7 @@ import {
 	listRecoverableSegmentJobs,
 	SourceCommitPendingError,
 } from "@/lib/desktop-recording-jobs";
+import { readCompletedRecordingManifest } from "@/lib/desktop-recording-verification";
 import {
 	type DesktopSegmentsFinalizationStatus,
 	queueDesktopSegmentsFinalization,
@@ -80,6 +81,7 @@ type LoadedDesktopSegmentsManifest =
 			status: "loaded";
 			video: typeof videos.$inferSelect;
 			manifest: Video.SegmentManifestType;
+			manifestJson: string;
 	  }
 	| { status: "already-finalized" }
 	| { status: "not-found" }
@@ -128,7 +130,7 @@ async function loadDesktopSegmentsManifest({
 		)
 			.pipe(Effect.mapError(getErrorMessage))
 			.pipe(runPromise);
-		return { status: "loaded", video, manifest };
+		return { status: "loaded", video, manifest, manifestJson: json };
 	} catch (error) {
 		return { status: "invalid-manifest", error: getErrorMessage(error) };
 	}
@@ -159,6 +161,11 @@ export async function completeDesktopSegmentsManifestAndQueue({
 		return { status: "manifest-changed" };
 	}
 	if (!loaded.manifest.is_complete) return { status: "source-incomplete" };
+	try {
+		readCompletedRecordingManifest(loaded.manifestJson);
+	} catch {
+		return { status: "source-incomplete" };
+	}
 	try {
 		const status = await queueDesktopSegmentsFinalization({
 			videoId,