Skip to content

Conversation

@ItsEeleeya
Copy link
Contributor

@ItsEeleeya ItsEeleeya commented Dec 7, 2025

Since @aerofoil/rive-solid-canvas doesn't support Rive's useDevicePixelRatio, this PR adds a wrapper function to manually call the proper function which makes Rive use the dpr for higher quality drawing.

Summary by CodeRabbit

  • Dependencies

    • Updated the Rive graphics library to the latest stable version (2.32.2) for improved animation support and performance.
  • Refactor

    • Animation/graphics helpers were reorganized into a local utility and imports adjusted for clearer structure and maintainability; no user-facing behavior or public APIs changed.

✏️ Tip: You can customize this high-level summary in your review settings.

richiemcilroy and others added 2 commits December 7, 2025 20:20
…e-cursor-option-to-settings-claude-4.5-opus-high-thinking-64f7

Add circle cursor option to settings
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Walkthrough

Moved Rive integration into a new local utility module, updated the @rive-app/canvas dependency version, and changed two route files to import the local createRive instead of the external package. No public API signatures were removed or altered.

Changes

Cohort / File(s) Change Summary
Dependency Version Update
apps/desktop/package.json
Bumped @rive-app/canvas from ^2.26.7 to ^2.32.2.
New Rive utility
apps/desktop/src/utils/rive.ts
Added createRive wrapper that delegates to rive-solid-canvas, exposing canvas and rive accessors and a RiveComponent, and sets up a reactive resize effect.
Imports updated to local util
apps/desktop/src/routes/(window-chrome)/settings/license.tsx, apps/desktop/src/routes/(window-chrome)/upgrade.tsx
Replaced imports of createRive from @aerofoil/rive-solid-canvas with ~/utils/rive; usage unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Review apps/desktop/src/utils/rive.ts for correct delegation to the underlying rive-solid-canvas API, SolidJS typings (Accessors, JSX), and reactive effect disposal.
  • Verify the two route files import and use the new local createRive without runtime regressions.
  • Quick check of package.json bump for any breaking API changes in @rive-app/canvas.

"I hopped along the code-lined trail,
Tuned the rive and set the sail,
Local home for canvases bright,
Softly humming pixels light,
🐇🥕"

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Use devicePixelRatio for rive in app' directly aligns with the PR's stated objective of adding support for devicePixelRatio in Rive rendering, which is implemented through the new wrapper function in rive.ts.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fcf5353 and 0395a55.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • apps/desktop/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/desktop/package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants