fix: honor playback speed settings in embeds - #2271
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedded videos now use the same default playback speed as share links: the video setting takes precedence, then the organisation setting, then Cap’s existing 1.2× fallback. This fixes embeds starting at 1.2× after an organisation has selected 1×, across MP4, HLS, and minimal embeds.
Validation: 69 focused tests pass across embed speed, playback/branding, oEmbed, Player.js, and share-page loading. Biome and scoped TypeScript checks pass for all four changed files. The new client regression cases failed before the fix. Browser playback has not been replayed; the shared local web runtime is in use by another task.
The PR appears safe to merge, with playback-speed resolution and propagation consistently implemented across embed variants.
Summary
Reviews (1) · Last reviewed commit: "fix: honor playback speed settings in em..."