Skip to content

improve: desktop recording and editor responsiveness #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richiemcilroy merged 4 commits into from
Sep 11, 2026
Merged

improve: desktop recording and editor responsiveness #2273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fca0fe
improve: desktop recording and editor responsiveness
richiemcilroy Sep 10, 2026
45369c5
fix: require explicit recording benchmark invocation
richiemcilroy Sep 11, 2026
091e0a4
fix: publish recording replacements without overwriting originals
richiemcilroy Sep 11, 2026
2e1f95e
fix: restart legacy recording replacements safely
richiemcilroy Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions apps/desktop-gpui/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions apps/desktop-gpui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ publish = false
name = "cap-gpui"
path = "src/main.rs"

[[example]]
name = "studio-finalization-benchmark"
path = "../../crates/recording/examples/studio-finalization-benchmark.rs"

[package.metadata.bundle]
name = "Cap GPUI"
identifier = "so.cap.desktop.gpui"
Expand All @@ -28,6 +32,7 @@ osx_info_plist_exts = ["resources/Info.plist"]
osx_url_schemes = ["cap-desktop"]

[dependencies]
cap-audio = { path = "../../crates/audio" }
# gpui — the wingleeio/zed fork Comet ships. The pinned rev carries f596cde
# ("destination alpha on transparent windows: Porter-Duff OVER, not additive"),
# which our transparent rounded main-window shell depends on.
Expand Down Expand Up @@ -183,6 +188,7 @@ windows-sys = { version = "0.59", features = [
"Win32_Security",
"Win32_System_SystemInformation",
"Win32_System_Threading",
"Win32_UI_Shell",
"Win32_UI_WindowsAndMessaging",
] }

Expand Down
9 changes: 2 additions & 7 deletions apps/desktop-gpui/dev.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,12 @@
# app persists its window state through CAP_GPUI_DEV_RESTORE and reopens where
# it was, and the swap waits out an in-flight recording (see dev_restore.rs).
set -uo pipefail
cd "$(dirname "$0")"
cd "$(dirname "$0")" || exit 1

STATE_FILE="$PWD/target/dev-restore.json"
BIN="$PWD/target/debug/cap-gpui"
BUILD=cargo

# Cargo.toml turns incremental off to keep the dep tree's caches off a full
# disk, but deps never rebuild in this loop -- the cache this creates is the
# app crate's only, and it takes a warm rebuild from ~41s to 3-23s.
export CARGO_INCREMENTAL=1

WATCH_PATHS=(src assets Cargo.toml)
[ -d resources ] && WATCH_PATHS+=(resources)
for crate in camera scap-targets recording timestamp utils project rendering editor export; do
Expand Down Expand Up @@ -84,7 +79,7 @@ while true; do
if [ "$CURRENT" != "$LAST" ]; then
LAST="$CURRENT"
echo "[dev] building..."
if "$BUILD" build; then
if "$BUILD" build --config profile.dev.package.cap-desktop-gpui.incremental=true; then
if [ -n "$APP_PID" ] || gpui_owns_session || instance_live; then
stop_app
start_app
Expand Down
Loading
Loading