fix: stabilize Studio recording and editor loading - #2278
Merged
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
richiemcilroy
changed the title
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Studio cannot start a segment on Resume (including low disk space), it now retains the paused recording and its saved segments so Retry or Stop still works. Failed startup resources are joined before returning; unconfirmed cleanup stays a terminal error rather than falsely acknowledging capture shutdown.
Tauri and GPUI recording controls reserve space for the drag handle, keep paused styling consistent, and show a bounded, readable disk-error panel with retry/save guidance. Multiple Tauri warnings share the existing issue indicator.
Tauri Recording quality settings now open through the registered route and use a theme-aware outline icon. GPUI editor loading uses subtle preview, sidebar, and timeline skeletons with a 180 ms fade directly into the first composed frame and ready controls. Existing editor readiness guards and timeline sizing are preserved, and failed loads stop pulsing.
Validation: 539 recording unit tests passed (3 ignored), focused recording check and Clippy passed, and native macOS tests passed for ordinary pause/resume plus failed second-resume followed by save or retry, including failure after screen pipeline setup. Saved media is checked for preservation and decodability. Desktop typecheck and 11 focused tests passed; GPUI check passed. The actual Tauri component passed 14 layout states across WebKit/Chromium at 320 × 150; native GPUI paused/error previews were visually checked at the same size.
Windows/Linux native UI was not exercised locally. The broader device timing harness has pre-existing audio tolerance failures on both unchanged baseline and candidate; this change does not claim to resolve those.
Recording-settings/editor validation: desktop TypeScript, scoped Biome, 44 focused settings/preparation tests, Rust formatting, and GPUI compilation passed. Native visual verification of the new editor loading presentation remains open.
The reviewed changes appear safe to merge, with no outstanding actionable failures identified.
Summary
Reviews (3) · Last reviewed commit: "fix: preserve editor readiness while ref..."