Fix duplicate retirement submission guard - #608
Merged
Oluwaseyi89 merged 1 commit intoAug 30, 2026
Conversation
|
@boalambo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes duplicate-retirement submissions in the client by closing the race window between a user click and React state re-render, and by attaching a client-generated idempotency key to each retirement request.
What changed
Why
The previous flow allowed a second submission to queue before the disabled state took effect, which could produce duplicate retirement requests. The client also did not send an idempotency key, which prevented the backend from distinguishing a genuine retry from a duplicate user action.
Validation
Verified with:
npx vitest run "src/components/retirement/InstantRetirementForm.test.tsx" "src/services/retirement.service.test.ts" --reporter=basicResult:
Closes #553