L1-278: Fix synthetic-network repo compilation #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the one provided with their repo is no longer able to build it (rust) due to a discovered bug in llvm (llvm/llvm-project#99547) - removed a no longer needed FIX for the build procedure of the synthetic-network docker image - retagging of the node-js local image
…pt/lib` in `Dockerfile.synthetic_network.build`.
Marcin-Radecki
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Splendid! So I can close this one right? daily-co/synthetic-network#16 It's not needed anymore
|
@Marcin-Radecki I'd leave the issue open, they still have a bug in their code. |
Merged
via the queue into
Cardinal-Cryptography:main
with commit Sep 6, 2024
479bdf0
15 checks passed
fixxxedpoint
deleted the
L1-278_fix_synthetic-network_repo_compilation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a custom version of the Dockerfile from the repo of the synthetic-network tool that uses a more specific version of the rust compiler. Also removed an ad-hoc fix for node-js images used by the original Dockerfile.
Type of change