A0-4324: Alter test_db_sync.sh to kill aleph-node after tests #1817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keenbytes
changed the title
Marcin-Radecki
approved these changes
Sep 30, 2024
keenbytes
changed the title
bartoszjedrzejewski
approved these changes
Sep 30, 2024
keenbytes
deleted the
tweak-test-db-sync-script-to-kill-aleph-node-after-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alters test_db_sync.sh script to kill aleph-node process once things are tested. It seems that cleaning github runner workspace, which is a next step that executes bunch of
rm -rfcommands, is failing because aleph-node running in the background keeps creating new files in the directories that are meant to be removed (hence, therm -rfcommands fail withDirectory not empty).