Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

pmikolajczyk41
Copy link
Contributor

Previously

  • 3 identical workflow files (difference only in a single line, specifying environment argument to an invoked action)
  • deploy action touched old shielder-relayer configuration in aleph-apps (using Kustomize)
  • possibility of changing Shielder contract address at the same time

Now

  • single workflow with additional argument (dev / stage / prod / all)
  • no option to change contract address (not needed & mixing two different responsibilities)
  • simple yq substitution instead of kustomization (shielder-relayer-v2 doesn't use overlays etc)

Copy link

github-actions bot commented May 15, 2025

Transaction NameMainCurrentDifference (%)
Deposit (size)20255202550.00000%
DepositERC20 (gas)17594021759426+0.00136%
DepositNative (gas)17412531741325+0.00413%
NewAccount (size)22867228670.00000%
NewAccountERC20 (gas)17932381793214-0.00134%
NewAccountNative (gas)19972641997300+0.00180%
Withdraw (size)21573215730.00000%
WithdrawERC20 (gas)18609391860747-0.01032%
WithdrawNative (gas)18606401860616-0.00129%

Copy link

github-actions bot commented May 15, 2025

📊 Coverage Report

📈 Total Coverage Summary

Type Covered Total Coverage
📝 Lines 1530 2155 🟠 70.99%
📄 Statements 1530 2155 🟠 70.99%
⚡ Functions 108 115 🟡 93.91%
🔀 Branches 265 275 🟡 96.36%

Coverage Legend

  • ✅ 100% Coverage
  • 🟡 80-99% Coverage
  • 🟠 50-79% Coverage
  • ❌ 0-49% Coverage

📁 File Coverage

📋 Detailed Coverage Report
File Lines Statements Functions Branches
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/deposit.ts 88.88% 88.88% 100% 85%
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/newAccount.ts 84.49% 84.49% 100% 78.94%
zkOS-monorepo/ts/shielder-sdk/src/actions/types.ts 100% 100% 100% 100%
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/utils.ts 97.33% 97.33% 100% 90.9%
🟠 zkOS-monorepo/ts/shielder-sdk/src/actions/withdraw.ts 77.04% 77.04% 87.5% 100%
zkOS-monorepo/ts/shielder-sdk/src/chain/contract.ts 1.89% 1.89% 0% 0%
zkOS-monorepo/ts/shielder-sdk/src/chain/relayer.ts 31.7% 31.7% 33.33% 50%
zkOS-monorepo/ts/shielder-sdk/src/client/actions.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/client/client.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/client/factories.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/client/types.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/constants.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/errors.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/index.ts 0% 0% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/accountFactory.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/accountRegistry.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/accountStateSerde.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/idManager.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/localStateTransition.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/chainStateTransition.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/historyFetcher.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/synchronizer.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/tokenAccountFinder.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/types.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/storage/storageManager.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/storage/storageSchema.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/types.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/utils.ts 100% 100% 100% 100%

Copy link
Contributor

@DamianStraszak DamianStraszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but only running it will tell us if it works :P

description: Environment to deploy to
type: choice
options:
- all (dev, stage, prod)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the intention behind the bracket, but can we make it just all -- I'm always scared to have whitespace in these kind of variables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shortened

# Conflicts:
#	.github/workflows/testnet-dev-build-and-deploy-shielder-relayer.yml
#	.github/workflows/testnet-stage-build-and-deploy-shielder-relayer.yml
@pmikolajczyk41 pmikolajczyk41 merged commit 02e5477 into main May 15, 2025
18 of 22 checks passed
@pmikolajczyk41 pmikolajczyk41 deleted the relayer-workflows branch May 15, 2025 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants