Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

kroist
Copy link
Collaborator

@kroist kroist commented Jul 22, 2025

No description provided.

Copy link

github-actions bot commented Jul 22, 2025

Transaction NameMainCurrentDifference (%)
Deposit (size)20255202550.00000%
DepositERC20 (gas)17660151765991-0.00136%
DepositERC20Fees (gas)17747271774715-0.00068%
DepositERC20FeesMemo (gas)17755771775541-0.00203%
DepositERC20Memo (gas)17667811766817+0.00204%
DepositNative (gas)17482571748389+0.00755%
DepositNativeFees (gas)17577331757781+0.00273%
DepositNativeFeesMemo (gas)17585231758583+0.00341%
DepositNativeMemo (gas)17661951766207+0.00068%
NewAccount (size)22867228670.00000%
NewAccountERC20 (gas)17996791799703+0.00133%
NewAccountERC20Fees (gas)18083911808427+0.00199%
NewAccountERC20FeesMemo (gas)17921641792032-0.00737%
NewAccountERC20Memo (gas)178334417833440.00000%
NewAccountNative (gas)17643231764311-0.00068%
NewAccountNativeFees (gas)18158511815815-0.00198%
NewAccountNativeFeesMemo (gas)177456417745640.00000%
NewAccountNativeMemo (gas)17650401765160+0.00680%
Withdraw (size)21573215730.00000%
WithdrawERC20 (gas)18671491867221+0.00386%
WithdrawERC20Fees (gas)18417931841769-0.00130%
WithdrawERC20FeesMemo (gas)184253518425350.00000%
WithdrawERC20Memo (gas)18338351833919+0.00458%
WithdrawNative (gas)18674331867457+0.00129%
WithdrawNativeFees (gas)18268371826777-0.00328%
WithdrawNativeFeesMemo (gas)18447281844788+0.00325%
WithdrawNativeMemo (gas)18182241818260+0.00198%

Copy link

github-actions bot commented Jul 22, 2025

📊 Coverage Report

📈 Total Coverage Summary

Type Covered Total Coverage
📝 Lines 1722 2435 🟠 70.71%
📄 Statements 1722 2435 🟠 70.71%
⚡ Functions 115 132 🟡 87.12%
🔀 Branches 277 292 🟡 94.86%

Coverage Legend

  • ✅ 100% Coverage
  • 🟡 80-99% Coverage
  • 🟠 50-79% Coverage
  • ❌ 0-49% Coverage

📁 File Coverage

📋 Detailed Coverage Report
File Lines Statements Functions Branches
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/deposit.ts 89.74% 89.74% 100% 85.71%
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/newAccount.ts 86.27% 86.27% 100% 80%
zkOS-monorepo/ts/shielder-sdk/src/actions/types.ts 100% 100% 100% 100%
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/utils.ts 97.33% 97.33% 100% 90.9%
🟠 zkOS-monorepo/ts/shielder-sdk/src/actions/withdraw.ts 78.14% 78.14% 87.5% 100%
zkOS-monorepo/ts/shielder-sdk/src/chain/contract.ts 1.8% 1.8% 0% 0%
zkOS-monorepo/ts/shielder-sdk/src/chain/relayer.ts 32.94% 32.94% 33.33% 50%
zkOS-monorepo/ts/shielder-sdk/src/client/actions.ts 100% 100% 100% 100%
🟡 zkOS-monorepo/ts/shielder-sdk/src/client/client.ts 88.13% 88.13% 71.42% 85.71%
zkOS-monorepo/ts/shielder-sdk/src/client/factories.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/client/types.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/constants.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/errors.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/index.ts 0% 0% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/protocolFees.ts 18.51% 18.51% 14.28% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/accountFactory.ts 100% 100% 100% 100%
🟡 zkOS-monorepo/ts/shielder-sdk/src/state/accountOnchain.ts 94.44% 94.44% 100% 77.77%
zkOS-monorepo/ts/shielder-sdk/src/state/accountRegistry.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/accountStateSerde.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/idManager.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/localStateTransition.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/chainStateTransition.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/historyFetcher.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/synchronizer.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync/tokenAccountFinder.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/types.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/storage/storageManager.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/storage/storageSchema.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/types.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/utils.ts 100% 100% 100% 100%
🟡 zkOS-monorepo/ts/shielder-sdk/src/utils/errorHandler.ts 93.33% 93.33% 100% 75%

tee/tf/main.tf Outdated
--name shielder-prover-proxy \
--restart always \
-p 3000:3000 \
--privileged \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of --privileged, we can use --security-opt seccomp=unconfined, which decreases security less and still works

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed as you suggest

tee/tf/main.tf Outdated

# Run the enclave
echo "Starting Nitro Enclave with CID=$${TEE_CID}"
nitro-cli run-enclave --cpu-count 2 --memory 2048 --enclave-cid $${TEE_CID} --eif-path /home/ec2-user/image.eif --debug-mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to add some flag/variable for --debug-mode? For production, we should not be using --debug-mode

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a tf variable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants