Feature/advanced biamp by craigmillard86 · Pull Request #187 · CarlosDerSeher/snapclient

craigmillard86 · 2026-01-17T21:00:23Z

PR: Advanced TAS58505 Bi-Amp Crossover with PEQ, Loudness Compensation, and UI Improvements

Summary

This PR introduces a comprehensive advanced bi-amp crossover system with parametric EQ, loudness compensation, and significant improvements to the web UI and HTTP server reliability.

Add bi-amp crossover with configurable high-pass/low-pass filters and 6-band parametric EQ per channel
Implement loudness compensation curves with zone-based volume adjustments
Add bi-amp preset export/import functionality for shareable speaker configurations
Expand PEQ to 6 bands with improved UI controls
Add dedicated DAC Settings and EQ tabs with full TAS5805M configuration support
Fix mobile browser reliability issues with HTTP server socket handling
Add retry logic and error recovery for DAC/EQ pages on resource-constrained connections

Key Features

Advanced Bi-Amp Crossover: Configurable crossover frequencies with independent high-pass and low-pass filters
6-Band Parametric EQ: Per-channel parametric equalization with frequency, gain, and Q controls
Loudness Compensation: ISO 226:2003 equal-loudness contour curves with configurable zones
Preset System: Export/import bi-amp configurations as shareable presets
DAC Settings UI: Full control over TAS5805M bridge mode, modulation, switching frequency, and analog gain
15-Band Graphic EQ: Alternative to parametric mode with ISO center frequencies

Bug Fixes

Fix player reconnection crash in bi-amp mode
Fix EQ UI gains showing 0 on page load before music starts
Guard tas5805m_loudness_apply with CONFIG_DAC_TAS5805M_EQ_SUPPORT to prevent build errors
Fix channel gains not being restored on device reboot
Fix WiFi power save interfering with low latency audio
Fix mobile UI loading errors for DAC/EQ pages with retry logic
Add Connection: close headers to large HTTP responses (EQ schema 64KB, DAC schema 36KB)
Increase delay between schema/settings requests to allow ESP32 memory recovery
Add HTTP server timeouts and connection backlog for improved socket handling

…DAC state tracking. Added debug logging.

…mic range

…mponent to apply stored settings at startup and expose settings structure to http component, Updated html for the UI

…l_settings component architecture. Fully data-driven front-end

…log gain to tas5805m_settings

…equency, analog gain. Added support for readonly parameters

The function uses tas5805m_write_biquad_coefficients which is only available when EQ support is enabled. Wrap the implementation in a preprocessor conditional to avoid implicit declaration errors when building without EQ support.

- Remove defer from script tags to ensure scripts load before DOMContentLoaded - Add automatic retry with 500ms delay for transient failures - Add 100ms delay between EQ schema/settings requests to reduce ESP32 memory pressure - Show actual error messages and add Retry button for user recovery - Add check for getRequest function availability on DAC page

- Keep max_open_sockets at 7 (LWIP_MAX_SOCKETS limit) - Add recv/send timeouts (5s) to cleanup idle connections faster - Increase backlog_conn to 10 for pending connection queue - Add Connection: close header to large schema responses (DAC/EQ) to free sockets immediately after 36KB/64KB transfers

- Add missing Connection: close header to EQ settings handler (16KB response) - Increase delay between EQ schema and settings requests from 100ms to 300ms - Allows ESP32 memory recovery after 64KB schema response before 16KB settings

The fault monitoring task was crashing with stack overflow when faults were detected. The tas5805m_decode_faults() function can make up to 12 ESP_LOGW calls with formatted strings, each consuming 200-400 bytes of stack for vsnprintf operations. Combined with I2C operations and task overhead, this exceeded the 2048 byte allocation. Increased stack from 2048 to 4096 bytes to provide adequate headroom.

anabolyc · 2026-01-22T17:21:29Z

@craigmillard86 can you include screeshot here for reference as well. I'm porting some of that into Raspberry Pi kernel driver, looking which options can be of use in Bi-Amp setup.

craigmillard86 · 2026-01-24T23:15:23Z

@craigmillard86 can you include screeshot here for reference as well. I'm porting some of that into Raspberry Pi kernel driver, looking which options can be of use in Bi-Amp setup.

No Problem, attached

# Conflicts: # components/lightsnapcast/player.c

CarlosDerSeher · 2026-02-28T14:11:38Z

Ok, so I missed that one and now there are conflicts @craigmillard86

craigmillard86 · 2026-04-03T22:38:20Z

@CarlosDerSeher have removed all the merge conflicts

Copilot

Pull request overview

This PR adds an “Advanced Bi-Amp” DSP configuration path for TAS5805M (active crossover + per-output PEQ + loudness), plus corresponding preset export/import/reset APIs and substantial web UI + HTTP server robustness improvements (mobile reliability, retries, socket cleanup).

Changes:

Introduces advanced bi-amp DSP + persistence (NVS), loudness compensation, and preset export/import/reset plumbing.
Extends EQ web UI to render the new Advanced Bi-Amp schema layout (sections/subgroups/radio) and adds mobile responsiveness + retry/debounce behavior.
Improves HTTP server reliability (timeouts/backlog, large-response connection close) and tightens query parsing/CORS behavior.

Reviewed changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
partitions.csv	Fixes missing partition index for `ota_1`.
docs/ADVANCED_BIAMP_USER_GUIDE.md	Adds end-user documentation for advanced bi-amp crossover/PEQ/loudness/presets.
components/ui_http_server/ui_http_server.c	Hardens URL decode + query parsing, modifies CORS handling, adds bi-amp preset/reset endpoints, adjusts HTTP server config/timeouts.
components/ui_http_server/html/styles.css	Adds mobile responsiveness improvements for shared styles.
components/ui_http_server/html/settings-ui.js	Adds radio controls, conditional visibility, and grouped renderers for bi-amp/loudness UI layouts.
components/ui_http_server/html/index.html	Adds responsive navigation styling for mobile.
components/ui_http_server/html/eq-settings.html	Adds bi-amp UI rendering, preset buttons, retry logic, and debounced setting updates.
components/ui_http_server/html/dac-settings.html	Adds retry logic and better error messaging if scripts aren’t loaded.
components/tas5805m_settings/tas5805m_settings.c	Adds advanced bi-amp + loudness settings persistence/apply, schema generation updates, and preset import/export/reset.
components/tas5805m_settings/tas5805m_biamp.c	New DSP/biquad coefficient generation and targeted apply helpers for advanced bi-amp.
components/tas5805m_settings/include/tas5805m_settings.h	Adds types/NVS keys/APIs for bi-amp, loudness, and presets; introduces new EQ UI mode.
components/tas5805m_settings/include/tas5805m_biamp.h	New public bi-amp DSP API and band allocation definitions.
components/tas5805m_settings/CMakeLists.txt	Adds `tas5805m_biamp.c` to the component build.
components/lightsnapcast/player.c	Minor formatting change.
components/custom_board/tas5805m/tas5805m.c	Adds I2C mutexing, fault task stack increase, loudness-on-volume-change hook, and biquad feedback sign convention adjustment.
components/custom_board/CMakeLists.txt	Adds dependency/include path wiring for `tas5805m_settings` when TAS5805M is enabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CarlosDerSeher · 2026-04-16T17:58:19Z

Also please address Copilot comments where necessary

…and cleanup fixes - Fix CORS origin validation: replace prefix matching with is_local_origin() that verifies next char is digit/terminator, validates 172.16-31 range - Add httpd_recv_all() helper to handle partial reads in all POST handlers - Add 32KB max body size check (413 Payload Too Large) to all POST handlers - Fix biquad read/write asymmetry: negate a1/a2 on read to match write convention - Remove mutex creation from portENTER_CRITICAL section in tas5805m_init() - Remove unused BW/LR filter type selector from UI (always Linkwitz-Riley) - Fix frontend URLs to use getBackendUrl() for preset export/import/reset/sendBeacon - Fix documentation treble frequency (~5 kHz -> ~4 kHz to match code) - Revert whitespace-only changes in player.c

craigmillard86 · 2026-04-23T20:19:06Z

Also please address Copilot comments where necessary

All now updated.

luar123 · 2026-04-24T05:16:41Z

The commit is missing here. You pushed to a different branch.

…and cleanup fixes - Fix CORS origin validation: replace prefix matching with is_local_origin() that verifies next char is digit/terminator, validates 172.16-31 range - Add httpd_recv_all() helper to handle partial reads in all POST handlers - Add 32KB max body size check (413 Payload Too Large) to all POST handlers - Fix biquad read/write asymmetry: negate a1/a2 on read to match write convention - Remove mutex creation from portENTER_CRITICAL section in tas5805m_init() - Remove unused BW/LR filter type selector from UI (always Linkwitz-Riley) - Fix frontend URLs to use getBackendUrl() for preset export/import/reset/sendBeacon - Fix documentation treble frequency (~5 kHz -> ~4 kHz to match code) - Revert whitespace-only changes in player.c

Replace Promise.all([schema, settings]) with staged sequential fetches (schema -> 300ms delay -> settings) in both the mode-change and auto-mode gain/preset reload paths, matching the pattern already used in loadSettings(). Prevents socket/memory issues on mobile clients.

craigmillard86 · 2026-04-24T07:21:36Z

The commit is missing here. You pushed to a different branch.

Done, pushed to my repo instead of @anabolyc

craigmillard86 · 2026-05-26T22:38:17Z

@CarlosDerSeher anything else needed on this branch?

CarlosDerSeher · 2026-05-27T03:24:05Z

I don't think so. It had conflicts but other than that I think it is ok

CarlosDerSeher · 2026-05-27T03:26:36Z

 static const char *TAG = "TAS5805M";

+/* Mutex for thread-safe I2C access */
+static SemaphoreHandle_t tas5805m_i2c_mutex = NULL;


I don't think we have this anywhere. Do we really need this?

CarlosDerSeher · 2026-05-27T03:29:53Z

 	httpd_config_t config = HTTPD_DEFAULT_CONFIG();
 	config.server_port = port;
-	config.max_open_sockets = 7;
+	config.max_open_sockets = 7;     // Max allowed by LWIP_MAX_SOCKETS config


Shouldn't we use the config value here?

CarlosDerSeher · 2026-05-27T03:30:51Z

I don't see any change

Andriy Malyshenko added 30 commits January 6, 2026 18:43

TAS5805M driver improvements. Sleep mode when mute. State object for …

28e24d5

…DAC state tracking. Added debug logging.

Set correct mute flag on DAC restore

048fdc3

Added revised state changes: independent MUTE flasg and DAC power mode

515daca

Volume implementation without a lookup tables

79e9950

Changed lower border of volume slider to -60dB to provide better dyna…

52b4f1e

…mic range

Updated Ui to manage DSP settings and change DSP flow. Updated DSP co…

1ae205e

…mponent to apply stored settings at startup and expose settings structure to http component, Updated html for the UI

post rebase cleanup

c33637e

fix build errors

1505272

refactored away DSP settings into dedicated component. aligned genera…

b908e45

…l_settings component architecture. Fully data-driven front-end

replaced hard coded flow count with DSP_FLOW_COUNT

a2f126d

Removed dsp_processor_switch_flow function

30e3f64

First steps in tas5805m settings page (wip)

7da1391

Add persistence for DAC mode, modulation mode, digital volume and ana…

1a5397a

…log gain to tas5805m_settings

Added UI for DAC settings: bridge mode, modulation mode, switching fr…

1f6dc7e

…equency, analog gain. Added support for readonly parameters

Added mixer implementation

dd91fbe

Added EQ related code to the tas5805m driver

d1f6f64

config changes

ece19f1

Added EQ mode (with persistance and restore on boot)

e7d67d1

Added 15-band equilizer

d385ae1

Added mode switch: 15-band EQ or EQ presets

86d77da

Added mixer compensation gains

db76ced

Apply tas5805m settings after DAc init passed (need I2S clock)

3d7092f

apply settings after I2S clock is present - fix

dc203ad

dsiable eq controls, when eq support is disabled

3cc92ec

Bugs with eq restore and build error fixes

eb06b6b

Eq vertical slider layout

131d2f2

Added dedicated tab for the EQ and refactored json API

f056afd

Removed BQ editor, restored develop version of the dsp_processor

c13a7f9

merge cleanup

5672d93

Post merge cleanup

f7ecade

craigmillard86 added 5 commits January 17, 2026 18:54

Revert chkInFrames handling to return -1 instead of defaulting to 1152

615cbf2

craigmillard86 added a commit to anabolyc/esp32-snapclient that referenced this pull request Jan 25, 2026

Merge PR CarlosDerSeher#187 into test

2a0596e

# Conflicts: # components/lightsnapcast/player.c

craigmillard86 added 3 commits January 26, 2026 00:00

fix: Make biamp conditional on EQ support being enabled

783db4d

fix: Add stub biamp functions when EQ support is disabled

b4ee16b

fix: Add missing string.h include for memset

6037764

Merge branch 'develop' into feature/advanced-biamp

8711a57

Copilot AI review requested due to automatic review settings April 3, 2026 22:34

Copilot started reviewing on behalf of craigmillard86 April 3, 2026 22:35 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

CarlosDerSeher reviewed Apr 16, 2026

View reviewed changes

Comment thread components/lightsnapcast/player.c

Comment thread docs/ADVANCED_BIAMP_USER_GUIDE.md Outdated

craigmillard86 added 2 commits April 24, 2026 08:20

Merge branch 'develop' into feature/advanced-biamp

f44edb2

CarlosDerSeher reviewed May 27, 2026

View reviewed changes

Conversation

craigmillard86 commented Jan 17, 2026

Uh oh!

anabolyc commented Jan 22, 2026

Uh oh!

craigmillard86 commented Jan 24, 2026

Uh oh!

CarlosDerSeher commented Feb 28, 2026

Uh oh!

craigmillard86 commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CarlosDerSeher commented Apr 16, 2026

Uh oh!

craigmillard86 commented Apr 23, 2026

Uh oh!

luar123 commented Apr 24, 2026

Uh oh!

craigmillard86 commented Apr 24, 2026

Uh oh!

craigmillard86 commented May 26, 2026

Uh oh!

CarlosDerSeher commented May 27, 2026

Uh oh!

CarlosDerSeher May 27, 2026

Choose a reason for hiding this comment

Uh oh!

CarlosDerSeher May 27, 2026

Choose a reason for hiding this comment

Uh oh!

CarlosDerSeher May 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants