Refactoring - #16
Open
CarlosHSF99 wants to merge 4 commits into
Open
Conversation
Owner
Author
|
It also contains the XML loading optimizations from the previous PR that wasn't merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project is now cleaner and easier to understand.
The generator and the engine now each have their respective Model classes.
The generator Model represents a collection of Point3 and writes .3d files.
The engine Model represents a VBO buffer and reads .3d files.
The transformations were separated into multiple files, each for each transform, and all are under the transform namespace.
The parsing module was removed and the wall of code was distributed among the classes that represent the XML elements.
GLUT callbacks were moved inside the World class so that the project doesn't have global state. It still has a static variable in main...