fix url with query string problem #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a video is downloaded from Firebase Storage, it's filename has "/" encoded as "%2F", and as a result, we need to use Uri.parse two times, to get the actual file name instead of the full Cloud Storage path.
Fix the parser for the downloaded file
VOIDCRUSHER
reviewed
Jan 20, 2021
| var req = await _client.get(fileUri); | ||
| var fileName = fileUri.pathSegments.last; | ||
| while (Uri.parse(fileName).pathSegments.length > 1) { | ||
| fileName = Uri.parse(fileName).pathSegments.last; |
There was a problem hiding this comment.
A simpler way might be the following:
var filename = basename(fileUri.path);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when image url with query string like 'https://firebasestorage.googleapis.com/v0/b/eventat-4ba96.appspot.com/o/2019-Metrology-Events.jpg?alt=media&token=bfc47032-5173-4b3f-86bb-9659f46b362a' can not pass the isImage check and download.