Skip to content

Conversation

MaddyRizvi
Copy link

Description of the Problem:

The layout for the CheckBox in the sorting_option.xml was not properly spaced, resulting in a cluttered appearance and inconsistent alignment.

Solution:

I adjusted the textSize, paddingStart, and marginStart for the CheckBox to improve its readability and visual alignment within the LinearLayout. Specifically:

  • Increased textSize to 18sp for better readability.
  • Set paddingStart and marginStart to 16dp for consistent spacing around the checkbox.

Why I Chose This Solution:

These changes adhere to common Android UI best practices, ensuring that the checkbox appears neatly aligned and readable across different screen sizes and densities.

Testing:

The changes have been tested through unit tests, static analysis (Lint, SpotBugs), and manual UI verification on a live device/emulator.

@TheLastProject
Copy link
Member

I agree it's not quite perfect, but I don't think this is really going as you intended it? I tested it on my Fairphone 3 and it looks noticeably worse and more misaligned:

Stable Your change
image image

These changes adhere to common Android UI best practices

Linking to the documentation of these best practices could help a lot btw :)

@TheLastProject TheLastProject marked this pull request as draft February 25, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants