Skip to content

AboutActivity to Jetpack Compose #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

AboutActivity to Jetpack Compose #2489

wants to merge 1 commit into from

Conversation

TheLastProject
Copy link
Member

@TheLastProject TheLastProject commented May 4, 2025 •
edited
Loading

  • Composify
  • Hide elements when they should be hidden
  • Don't crash when clicking an element
  • Fix tests
  • Remove colour selection options in Catima (to simplify migration)
  • Ensure consistency with other activity designs

theimpulson
theimpulson reviewed May 5, 2025
View reviewed changes
app/src/main/java/protect/card_locker/AboutActivity.kt Outdated
true
setContent {
MaterialTheme {
Scaffold(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would extract the logic for the actual screen content in a separate function. That would make it easier to preview the UI and test it with fake data. Example, Documentation

app/src/main/java/protect/card_locker/ui/AboutActivity.kt Outdated
)
}
}
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new line? Maybe also a Preview?

theimpulson
theimpulson reviewed May 5, 2025
View reviewed changes
@TheLastProject TheLastProject force-pushed the feature/aboutCompose branch 2 times, most recently from 80a7ef9 to d3f7549 Compare May 7, 2025 18:30
@TheLastProject TheLastProject force-pushed the feature/aboutCompose branch 4 times, most recently from 437a681 to e79efe2 Compare June 4, 2025 11:30
@TheLastProject TheLastProject mentioned this pull request Jun 4, 2025
Closed
@TheLastProject TheLastProject force-pushed the feature/aboutCompose branch from e79efe2 to d14f5c8 Compare June 4, 2025 12:44
@TheLastProject TheLastProject mentioned this pull request May 3, 2025
Open
27 tasks
@TheLastProject
Copy link
Member Author

Main blocker here is that I haven't found the time to deal with fixing the tests yet (quite a different way of testing) and I'm hesitant to just remove the tests (though maybe I should to at least progress somewhat).

I think the general code is probably pretty OK by now, just needs the custom colour support removed for consistency between XML and Compose.

@vijay2909
Copy link

Thanks for the update! I took a look and went ahead with some optimizations in AboutActivity. I’ve also fixed a few of the existing tests and added some new ones to improve coverage. Hopefully, this helps unblock some of the progress you mentioned. Let me know if you’d like me to push these changes for review or if you’d prefer I open a separate PR.

@vijay2909 vijay2909 mentioned this pull request Oct 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@theimpulson theimpulson theimpulson left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheLastProject @vijay2909 @theimpulson