Skip to content

Conversation

matuspetro
Copy link

@matuspetro matuspetro commented Oct 7, 2025

  1. Removed condition that blocked image comparison
  2. Changed comparison logic from ID-based to cardID-based to prevent duplicates on repeated import

@TheLastProject
Copy link
Member

Added unit tests for Utils class

These tests don't seem relevant to this PR. Can you please split that into another PR, to keep this one focused on the change it is supposed to fix? That makes reviewing much easier.

@matuspetro matuspetro force-pushed the card-duplication-issue-#2349 branch from a0a0020 to 4bf0862 Compare October 11, 2025 19:41
@matuspetro
Copy link
Author

@TheLastProject I removed tests from this PR.

@TheLastProject
Copy link
Member

I'm a bit confused, you seem to just be checking if the existing and to-import card both have images and the same ID? That doesn't sound like it fixes images being detected as different when they aren't. Instead, you're now most likely overwriting images which aren't the same, which would be way worse! Unless I'm misreading your change somehow?

@matuspetro
Copy link
Author

I tested every scenario I could think of. If you try it and find a bug, please let me know and I will fix it.

@matuspetro
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants