-
Notifications
You must be signed in to change notification settings - Fork 36
feat: async CSV user import #1174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
niStee
wants to merge
6
commits into
CatoTH:main
Choose a base branch
from
niStee:feature/csv-user-import
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f66e125
feat: implement async CSV user import
niStee 379c74f
Address review comments on CSV import PR #1174
niStee 3aabc0c
Fix translation strings in view and add missing keys to DE/EN admin.php
niStee 91e78a7
refactor: merge UserAdminCsvImport into UserAdminCreate
niStee bc44e79
Bugfixes
CatoTH e04203b
docs: add self to AUTHORS file
niStee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| email,first_name,last_name,organization,groups | ||
| ada.lovelace@example.com,Ada,Lovelace,Volt Europa,"Delegates" | ||
| alan.turing@example.com,Alan,Turing,, | ||
| grace.hopper@example.com,Grace,Hopper,Volt Germany,"Admin, Delegates" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <?php | ||
|
|
||
| /** @var \Codeception\Scenario $scenario */ | ||
| use Tests\Support\AcceptanceTester; | ||
|
|
||
| $I = new AcceptanceTester($scenario); | ||
| $I->populateDBData1(); | ||
|
|
||
| $I->wantTo('Test CSV User Import JS Frontend Logic'); | ||
| $I->loginAndGotoStdAdminPage()->gotoUserAdministration(); | ||
|
|
||
| // Ensure the form is accessible via the opener | ||
| $I->clickJS('.addUsersOpener.csv'); | ||
|
|
||
| // Form and elements should be visible | ||
| $I->seeElement('#csvImportForm'); | ||
| $I->seeElement('#csvSubmitBtn'); | ||
|
|
||
| // Progress container should be hidden initially | ||
| $I->dontSeeElement('#csvProgressContainer:not(.hidden)'); | ||
|
|
||
| // Remove the required attribute so we can submit the form without an actual file, | ||
| // triggering the JS submit event instead of HTML5 validation | ||
| $I->executeJS("document.querySelector('input[name=\"csvFile\"]').removeAttribute('required');"); | ||
|
|
||
| // Click the submit button | ||
| $I->clickJS('#csvSubmitBtn'); | ||
|
|
||
| // The JS logic should catch the submit, prevent default, and show the progress container | ||
| $I->wait(0.5); | ||
| $I->seeElement('#csvProgressContainer:not(.hidden)'); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.