2783 changes in identifier for oai pmh records#2786
Conversation
| * https://www.openarchives.org/OAI/2.0/guidelines-oai-identifier.htm. | ||
| * eg (oai:www.wbc.poznan.pl:568432). | ||
| */ | ||
| UseNewPBIIdentifierScheme; |
There was a problem hiding this comment.
The identifier scheme is not PBI specific, right? It's an implementation of the OAI-PMH specification. So I would name it maybe UseOAIStrictIdentifierScheme instead, or similar.
| + this.systemConfig.getDataverseServer() | ||
| + "</repositoryIdentifier>" | ||
| + "<delimiter>:</delimiter>" | ||
| + "<sampleIdentifier>oai:example.org:doi%3A10.18150%2FAB1CD2</sampleIdentifier>" |
There was a problem hiding this comment.
Nit: We could already use the the actual repository identifier instead of example.org.
| private String getIdOf(final OAIRecord record) { | ||
| if (this.systemConfig.useNewPBIIdentifierScheme()) { | ||
| return "oai:" + this.systemConfig.getDataverseServer() + ':' | ||
| + URLEncoder.encode(record.getGlobalId()); |
There was a problem hiding this comment.
Shouldn't we use a local id instead? Well, the global id should always denote the same metadata item throughout its lifecyle, as we use it as well in links to datasets. So I guess this should be fine.
There was a problem hiding this comment.
From #2783
"For object identifier we should use transformed persistent identifiers that we already use, so doi/hdl without forbidden characters."
I think it means global IDs.
…ecord verb to accept identifier parameter in both formats
lbownik
force-pushed
the
2783_Changes_in_Identifier_for_OAI_PMH_records
branch
from
c939641 to
df430ec
Compare
3 participants
No description provided.