2787 advanced search for geonames#2790
Closed
lbownik wants to merge 14 commits into
Closed
Conversation
…/dataverse into 2736_Import_Geonames_Data_3
rscipien
reviewed
May 23, 2025
| : new QueryPart(QUERY, queryFragment); | ||
| } | ||
|
|
||
| private String createQueryFramgment() { |
Contributor
There was a problem hiding this comment.
typo createQueryFramgment - > createQueryFragment
| } | ||
|
|
||
| private String createQueryFramgment() { | ||
| if (this.id == null & this.label == null) { |
Contributor
There was a problem hiding this comment.
It was intended to use single &
| datasetFieldType.getDescription(), | ||
| GEONAME, datasetFieldType); | ||
| } | ||
| @Override |
Contributor
There was a problem hiding this comment.
Probably no needed if we call parent implementation super.getSearchFieldType();
lbownik
force-pushed
the
2736_Import_Geonames_Data_3
branch
3 times, most recently
from
ab1dec2 to
e7daa25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.