2795 fix various issues with saving search results to file feature#2797
Merged
lbownik merged 3 commits intoMay 28, 2025
Merged
Conversation
rscipien
approved these changes
May 27, 2025
diasf
approved these changes
May 27, 2025
| } | ||
|
|
||
| public boolean isExportableToFile() { | ||
| return !this.fieldType.equals(EMAIL); |
Collaborator
There was a problem hiding this comment.
Nit: To make the "why?" more obvious, what about renaming the method to isAccessRestricted or isConfidential?
|
|
||
|
|
||
| public boolean isExportToFile() { | ||
|
|
Collaborator
There was a problem hiding this comment.
Do we need to have a migration script to unset this flag for EMAIL fields on running instances?
Contributor
Author
There was a problem hiding this comment.
No. this feature is not in production yet.
lbownik
force-pushed
the
2795_Fix_various_issues_with_saving_search_results_to_file_feature
branch
from
501f017 to
dad3ae9
Compare
lbownik
deleted the
2795_Fix_various_issues_with_saving_search_results_to_file_feature
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2795 Fix various issues with saving search results to file feature