Closes #2804: Allow to append extra javascript code via extension#2805
Merged
Merged
Conversation
sniewczas
approved these changes
May 29, 2025
diasf
approved these changes
May 30, 2025
madryk
force-pushed
the
feature/allow_to_include_javascript_via_extension
branch
from
f724663 to
a9620be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the possibility to add some javascript code using extension.
In our case we want to be able to modify dataset create form. We want to be able to append a button next to one of the field. After clicking this button javascript code will calculate area that is selected on the map with polygon:
Changes in inputs for dataset fields (for example in
textInputField.xhtml) are for easier selecting fields that are interesting for us using javascript (possibly we could live without this change but it would be quite hard to write a selector for those fields).