3289 harvest via oai pmh of rein d space fails#3321
Open
lbownik wants to merge 33 commits into
Open
Conversation
added 30 commits
July 1, 2026 12:21
…pes of exceptions caught
added 2 commits
July 2, 2026 12:08
rscipien
reviewed
Jul 3, 2026
| if(this.protocol == null || this.authority == null || this.identifier == null) { | ||
| return ""; | ||
| } else if(HTTP_PROTOCOL.equals(this.protocol) || HTTPS_PROTOCOL.equals(this.protocol)) { | ||
| return this.protocol + ':' + this.protocol + "://" + this.authority + this.identifier; |
Contributor
There was a problem hiding this comment.
Two time this.protocol this was intended?
| public GlobalId(final String identifierString) { | ||
| final int index1 = identifierString.indexOf(':'); | ||
| if (index1 > 0) { // ':' found with one or more characters before it | ||
| if(identifierString.startsWith(HTTPS_PROTOCOL)) { |
Contributor
There was a problem hiding this comment.
Missing space between if (
| } catch (final MalformedURLException e) { | ||
| throw new IllegalArgumentException(e); | ||
| } | ||
| } else if(identifierString.startsWith(HTTP_PROTOCOL)) { |
Contributor
There was a problem hiding this comment.
Missing space between if {
Comment on lines
+114
to
+122
| final ArrayList<Node> identifiers = getNodes(document, "identifier"); | ||
| if(identifiers.isEmpty()) { | ||
| throw new EJBException("Missing dc:identifier xml element"); | ||
| } | ||
| for(final Node node : identifiers) { | ||
| version.addField(newField(otherId, null). | ||
| addChild(newField(otherIdValue, node.getTextContent()))); | ||
| } | ||
| dataset.setGlobalId(createGlobalId(identifiers)); |
Contributor
There was a problem hiding this comment.
Maybe this code could be moved where title is parsed. Both are required fields so maybe could be in the same place
| if (harvestingClient == null || harvestingClient.getDataverse() == null) { | ||
| public Dataset doImportHarvestedDataset(final DataverseRequest request, | ||
| final HarvestingClient client, final String identifier, | ||
| final HarvestImporterType importType, final String xml) throws ImportException { |
Contributor
There was a problem hiding this comment.
I would not change last parameter from metadata -> xml. In OAI-PMH specification content is called metadata
|
|
||
| private GlobalId createGlobalId(final ArrayList<Node> identifierNodes) { | ||
|
|
||
| final List<String> identifiers = identifierNodes |
Contributor
There was a problem hiding this comment.
If in this code we are only interested in first id, maybe just get first id and the do the logic without without for each type? final Optional<GlobalId> doi = identifiers .stream() .filter(GlobalId::isDOI) .findFirst()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.